Scheduler Framework based PredicateChecker - followups

[losipiuk]

This is an umbrella issue to list followup items to be addressed after merging in #2796

• Do not return errors from ClusterSnapshot methods for which it does not make sense (Cleare, Revert?, Get*, RemovePod?, RemoveNode?)
• Pass nodeName to RemovePod to avoid costly iteration over all nodes
• Refactor errors in basic_cluster_snapshot.go.
• Remove deprecated_scheduler_snapshot
• N/A - already resolved Add list of nodes (node names?) to FitsAny. Use that to optimize number of PreFilter calls in binpacking.
• Remove SnapshotClusterState() and all related code (ex. keeping listers in PredicateChecker).
• Add unit tests for BasicClusterSnaphsot (share with DeltaClusterSnapshot)
  • Assert cached lists are invalidated on Commit()/modify (including the scenario described in Add delta snapshot implementation #2799 (comment))
• Address TODOs in predicates_checker_interface.go
  • Forget FakeNodeInfoForNodeName ever existed
• Address every TODO(scheduler_framework_migration).
• Cleanup mess in scale-down so we always use ClusterSnapshot as source of truth (see comments below)
• Clean up how we calculate podDestinations list so it works with snapshot.
• Consider if we could do a single FitsAny call in findPlaceFor (instead of tryNodeForPod in a loop) .
• Investigate what happens if there is "pending" pod in cluster with nodeName pointing to node which does not exist in cluster; fix if needed
• Check if GPU hack still works after removing IsNodeReadyAndSchedulablePredicate
• Pass context Estimate(), rather that PredicateChecker and ClusterSnapshot to EstimateBuilder
• Create issue for AWS about failing TestGetRegion
• Expose separate list of cheap and expensive scheduler plugins kubernetes#87822

[gjtempleton]

I've already got a fix for the failing TestGetRegion in the closed PR #2750 - will open a separate PR for that now.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.