Scheduler Framework based PredicateChecker #2796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er (3fca0a6) Change-Id: Id9b4508a870fbf89ef78713ea9b89a046bf2a445
It seems it is not needed any more
19 tasks
k8s-ci-robot
added
the
size/XXL
62 tasks
k8s-ci-robot
added
the
cncf-cla: yes
losipiuk
force-pushed
the
lo/scheduler-framework-poc3
branch
from
af23ae7 to
4b30a6f
Compare
This is temporary hack. We should stop using for-go-proj.sh to verify cluster autoscaler and migrate to directly calling make. Change-Id: I0c41c918f78cdfa0e5fd0dd60139a54db90540ea
MaciekPytel
added
area/cluster-autoscaler
area/core-autoscaler
|
/lgtm edit: obviously it will really only 'look good' after follow-ups are addressed, but it's not sustainable to keep working on this in a feature branch. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MaciekPytel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final version of PR migrating PredicateChecker to scheduler framework.
Review already done in #2709.
List of outstanding items to be addressed as followups: #2797