Skip to content

Update cluster-autoscaler godeps on master #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2018
Merged

Update cluster-autoscaler godeps on master #1446

merged 2 commits into from
Nov 26, 2018

Conversation

losipiuk
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 26, 2018
@aleksandra-malinowska
Copy link
Contributor

kubernetes.sync

@losipiuk
Copy link
Contributor Author

https://github.com/kubernetes/autoscaler/pull/1446/files#diff-1bb6f9325d0fa20db0ad737ee0ff9cfa

@aleksandra-malinowska
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleksandra-malinowska

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2018
@k8s-ci-robot k8s-ci-robot merged commit e7dd383 into kubernetes:master Nov 26, 2018
@feiskyer
Copy link
Member

@losipiuk @aleksandra-malinowska Any reasons for rolling the kubernetes version back? Just noticed the master branch is still using vendor from kubernetes v1.12.

@losipiuk
Copy link
Contributor Author

Any reasons for rolling the kubernetes version back? Just noticed the master branch is still using vendor from kubernetes v1.12.

I am not sure now but I do not think it was intentional. We should update vendor on master against the newest k8s release there is right now.
Probably v1.15.0-alpha.0 is the way to go right now.

@feiskyer
Copy link
Member

OK, let me do that.

@feiskyer
Copy link
Member

Just find an issue because of old-versioned packages.

@feiskyer feiskyer mentioned this pull request Feb 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@aleksandra-malinowska aleksandra-malinowska

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@losipiuk @aleksandra-malinowska @k8s-ci-robot @feiskyer