Skip to content

Update CA godeps to Kubernetes v1.15.0-alpha.0 #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 21, 2019
Merged

Update CA godeps to Kubernetes v1.15.0-alpha.0 #1708

merged 7 commits into from
Feb 21, 2019

Conversation

feiskyer
Copy link
Member

Update CA godeps to Kubernetes v1.15.0-alpha.0, and also change some Go libraries to their new versions.

Refer #1446 (comment).

/assign @losipiuk

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Feb 21, 2019
@aleksandra-malinowska
Copy link
Contributor

/lgtm
/approve

Thanks! Really appreciate the contribution here, updating Godeps is a pain.

I've branched cluster-autoscaler-release-1.14 before merging this, as we should probably update Godeps there to Kubernetes 1.14 branch closer to the release (tracked in #1710).

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleksandra-malinowska

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2019
@mwielgus mwielgus removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Feb 21, 2019
@mwielgus mwielgus removed sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Feb 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0968736 into kubernetes:master Feb 21, 2019
@mwielgus
Copy link
Contributor

Just out of curiosity. Why do we need it 1.15 deps right now?

@aleksandra-malinowska
Copy link
Contributor

It's just sync to master, as far as I understand. We haven't done it in a while, so cloud providers' SDKs are quite stale.

@feiskyer feiskyer deleted the update-ca-godeps branch February 21, 2019 12:19
@feiskyer
Copy link
Member Author

Yep, sync to master. Before this, kubernetes v1.12 is used in master branch, which is really old.

@losipiuk
Copy link
Contributor

Thanks a lot @feiskyer !

@tghartland tghartland mentioned this pull request Feb 21, 2019
Merged
This was referenced Feb 26, 2019
Merged
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Feb 26, 2019
@k8s-ci-robot
Merge pull request #1729 from feiskyer/cluster-autoscaler-release-1.2
e14ad46 
Cluster Autoscaler 1.2: cherry-picks of #1641, #1703 and #1708
k8s-ci-robot added a commit that referenced this pull request Feb 26, 2019
@k8s-ci-robot
Merge pull request #1730 from feiskyer/cluster-autoscaler-release-1.3
132fcaf 
Cluster Autoscaler 1.3: cherry-picks of #1641, #1703 and #1708
k8s-ci-robot added a commit that referenced this pull request Feb 26, 2019
@k8s-ci-robot
Merge pull request #1731 from feiskyer/cluster-autoscaler-release-1.13
449c654 
Cluster Autoscaler 1.13: cherry-picks of #1641, #1703 and #1708
k8s-ci-robot added a commit that referenced this pull request Feb 26, 2019
@k8s-ci-robot
Merge pull request #1732 from feiskyer/cluster-autoscaler-release-1.12
4bba197 
Cluster Autoscaler 1.12: cherry-picks of #1641, #1703 and #1708
yaroslava-serdiuk pushed a commit to yaroslava-serdiuk/autoscaler that referenced this pull request Feb 22, 2024
@jdevries3133
fix: typo in, "Why Kueue?" (kubernetes#1708)
7fe3ad4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguslees anguslees Awaiting requested review from anguslees

@apelisse apelisse Awaiting requested review from apelisse

Assignees

@losipiuk losipiuk

@aleksandra-malinowska aleksandra-malinowska

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@feiskyer @aleksandra-malinowska @k8s-ci-robot @mwielgus @losipiuk