Skip to content

Beta/5295: KYAML beta updates #5566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

Beta/5295: KYAML beta updates #5566

merged 1 commit into from
Sep 30, 2025
+17 −9

Conversation

rxinui
Copy link
Contributor

@rxinui rxinui commented Sep 24, 2025

  • One-line PR description: update README.md and keps files to include beta changes
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 24, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @rxinui!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Sep 24, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @rxinui. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 24, 2025
@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Sep 24, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG CLI Sep 24, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 24, 2025
@rxinui
Copy link
Contributor Author

rxinui commented Sep 24, 2025

@soltysh

@soltysh
Copy link
Contributor

soltysh commented Sep 24, 2025

/ok-to-test
/assign

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 24, 2025
@soltysh soltysh mentioned this pull request Sep 24, 2025
Open
15 tasks
rxinui
rxinui commented Sep 24, 2025
View reviewed changes
soltysh
soltysh reviewed Sep 25, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but this looks mostly good

@rxinui
Copy link
Contributor Author

rxinui commented Sep 25, 2025

Changes have been applied. Documentation updates is linked to kubernetes/website#52523

soltysh
soltysh reviewed Sep 26, 2025
View reviewed changes
@rxinui rxinui requested a review from soltysh September 26, 2025 16:18
soltysh
soltysh approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold
for @jpbetz to have a chance to look at PRR

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 26, 2025
thockin
thockin reviewed Sep 29, 2025
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the assistance!

/approve
/lgtm

@rxinui
Copy link
Contributor Author

rxinui commented Sep 29, 2025

@thockin my pleasure, anytime!

jpbetz
jpbetz approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
For PRR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, rxinui, soltysh, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Contributor

soltysh commented Sep 30, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2025
@k8s-ci-robot k8s-ci-robot merged commit b52bc74 into kubernetes:master Sep 30, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Sep 30, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG CLI Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@jpbetz jpbetz jpbetz approved these changes

@soltysh soltysh soltysh approved these changes

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@soltysh soltysh

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG CLI
Status: Done
Milestone
v1.35
Development

Successfully merging this pull request may close these issues.
5 participants
@rxinui @k8s-ci-robot @soltysh @jpbetz @thockin