-
Notifications
You must be signed in to change notification settings - Fork 15.1k
KYAML beta updates on docs #52523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KYAML beta updates on docs #52523
Conversation
Welcome @rxinui! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
from sig-cli pov
LGTM label has been added. Git tree hash: 4e5b1a2c6b923d030234af61ee9e284c4aeff05a
|
/assign @salaxander |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For beta, we also need a reference to the KYAML format.
I expect that this PR should be the change that documents the KYAML format. Is that right? If you / the SIG want to, you can instead open a separate – perhaps placeholder – PR for the format reference work, and then this can merge separately.
Signed-off-by: rxinui <[email protected]>
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
Will do that then. Thank you @lmktfy, changes are ready for a second review! |
Ok, cool. Where's that placeholder? |
Here #52583 As this is my first PR placeholder, please let me know if I did something wrong :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 4278e30cbe00f18d91cecfca20049e9db1a22540
|
Pretty small change, so: |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmktfy, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Update KYAML output description to remove alpha-specific informationm, as it is now in beta stage.
Ref kubernetes/enhancements#5295
Linked to https://github.com/kubernetes/enhancements/pull/5566/files#r2376196149
CC: @soltysh @lmktfy