Skip to content

Conversation

rxinui
Copy link

@rxinui rxinui commented Sep 25, 2025

Description

Update KYAML output description to remove alpha-specific informationm, as it is now in beta stage.

Ref kubernetes/enhancements#5295
Linked to https://github.com/kubernetes/enhancements/pull/5566/files#r2376196149

CC: @soltysh @lmktfy

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @rxinui!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 25, 2025
@rxinui rxinui changed the base branch from main to dev-1.35 September 25, 2025 12:48
Copy link

netlify bot commented Sep 25, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 6780d7f
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68d83eb658eb88000855da1b
😎 Deploy Preview https://deploy-preview-52523--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@soltysh soltysh mentioned this pull request Sep 26, 2025
15 tasks
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
from sig-cli pov

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4e5b1a2c6b923d030234af61ee9e284c4aeff05a

@soltysh
Copy link
Contributor

soltysh commented Sep 26, 2025

/assign @salaxander
for doc approval

Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For beta, we also need a reference to the KYAML format.

I expect that this PR should be the change that documents the KYAML format. Is that right? If you / the SIG want to, you can instead open a separate – perhaps placeholder – PR for the format reference work, and then this can merge separately.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2025
Copy link

netlify bot commented Sep 27, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 6780d7f
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/68d83eb64b20740008299b2d

@rxinui
Copy link
Author

rxinui commented Sep 27, 2025

If you / the SIG want to, you can instead open a separate – perhaps placeholder – PR for the format reference work,

Will do that then.

Thank you @lmktfy, changes are ready for a second review!

@lmktfy
Copy link
Contributor

lmktfy commented Sep 29, 2025

Ok, cool. Where's that placeholder?

@rxinui
Copy link
Author

rxinui commented Sep 29, 2025

Ok, cool. Where's that placeholder?

Here #52583

As this is my first PR placeholder, please let me know if I did something wrong :)

Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4278e30cbe00f18d91cecfca20049e9db1a22540

@lmktfy
Copy link
Contributor

lmktfy commented Sep 29, 2025

Pretty small change, so:
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0ab1e38 into kubernetes:dev-1.35 Sep 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants