-
Notifications
You must be signed in to change notification settings - Fork 908
build-image: Promote kube-cross v1.13.9-1 images #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CIP snapshot outputs images sorted by digest, instead of tag. This will make diffs easier in the future when running a snapshot. Signed-off-by: Stephen Augustus <[email protected]>
Signed-off-by: Stephen Augustus <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold for another look
@justaugustus can you squash the commits? |
@bartsmykla -- I purposely split the commits so the diffs are separate; one is a no-op reordering and the other is an image promotion. |
It should be in different PR then |
checksums are correct though /unhold |
This is commonly done in the same PR to make reviews easier. |
It doesn't mean it's a good practice though |
@justaugustus you don't need a separate entry for |
"sha256:8d3fd0e3e126b085d4475f1954cc394a2ebea908f370095eb7463d2b1f4dbfdd": ["v1.12.17-1"] | ||
"sha256:df0a50772214025040ea31144a731b5fa76944cbfc9c87db05af98e4aa39aa7f": ["v1.13.6-1"] | ||
"sha256:0c821cd481e9bbfc9d380290d1401a856e9c2bc0f8d0673fc1519e9bef408d1d": ["v1.13.8-1"] | ||
sha256:0c821cd481e9bbfc9d380290d1401a856e9c2bc0f8d0673fc1519e9bef408d1d: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
personally not a fan of making this more lines just because.
what did sorting by digest accomplish ...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guessing this is what a yaml normalizer outputs? (sorting keys, unquoting strings that don't need quotes, etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(though I tend to agree... makes finding the shas for a specific version or range of versions hard)
(Companion PR to kubernetes/release#1200, kubernetes/kubernetes#89275, kubernetes/release#1140)
CIP snapshot outputs images sorted by digest, instead of tag.
This will make diffs easier in the future when running a snapshot.
Signed-off-by: Stephen Augustus [email protected]
/assign @BenTheElder @cblecker @liggitt @dims @listx
cc: @kubernetes/release-engineering
In kubernetes/kubernetes#89275, specifically
d37aed360f16f5a931e14671042e7965b96a0101
, I temporarily pointed at the staging kube-cross image and we can see successes on the expected jobs:pull-kubernetes-cross
: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/89275/pull-kubernetes-cross/1241156938012561410/pull-kubernetes-verify
: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/89275/pull-kubernetes-verify/1241156938058698753Snapshot from
sigs.k8s.io/k8s-container-image-promoter
:Validate: