Skip to content

build-image: Promote kube-cross v1.13.9-1 images #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions k8s.gcr.io/images/k8s-staging-build-image/images.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
- name: kube-cross
dmap:
"sha256:97e77164ddc1f9ab56bcbab3e2895b882097b1eabd820497e894f41c0e4908fe": ["v1.12.12-1"]
"sha256:8d3fd0e3e126b085d4475f1954cc394a2ebea908f370095eb7463d2b1f4dbfdd": ["v1.12.17-1"]
"sha256:df0a50772214025040ea31144a731b5fa76944cbfc9c87db05af98e4aa39aa7f": ["v1.13.6-1"]
"sha256:0c821cd481e9bbfc9d380290d1401a856e9c2bc0f8d0673fc1519e9bef408d1d": ["v1.13.8-1"]
sha256:0c821cd481e9bbfc9d380290d1401a856e9c2bc0f8d0673fc1519e9bef408d1d:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally not a fan of making this more lines just because.
what did sorting by digest accomplish ...?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guessing this is what a yaml normalizer outputs? (sorting keys, unquoting strings that don't need quotes, etc)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(though I tend to agree... makes finding the shas for a specific version or range of versions hard)

- v1.13.8-1
sha256:3b963befb3b660a859f51bc8212ff72a9ded9ff1495829c4d9cc4bbf676c80d8:
- v1.13.9-1
sha256:8d3fd0e3e126b085d4475f1954cc394a2ebea908f370095eb7463d2b1f4dbfdd:
- v1.12.17-1
sha256:97e77164ddc1f9ab56bcbab3e2895b882097b1eabd820497e894f41c0e4908fe:
- v1.12.12-1
sha256:df0a50772214025040ea31144a731b5fa76944cbfc9c87db05af98e4aa39aa7f:
- v1.13.6-1
- name: kube-cross-amd64
dmap:
sha256:60e119bc59d8e6c77ddf159af0a682d0634249e3baca69d5be2972d00942ff51:
- v1.13.9-1