Refactor kubepkg options into own package #1285
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/release-eng
| func run(opts *options.Options) error { | ||
| client := kubepkg.New(opts) | ||
| builds, err := client.ConstructBuilds() | ||
| if err != nil { | ||
| return errors.Wrap(err, "running kubepkg") | ||
| } | ||
| return client.WalkBuilds(builds, ro.architectures, ro.specOnly) | ||
| return client.WalkBuilds(builds) | ||
| } |
There was a problem hiding this comment.
I think this looks like we wanted to have it. Ref https://github.com/kubernetes/release/pull/1282/files#r424507497
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
There was a problem hiding this comment.
@saschagrunert -- Really nice cleanup! Just a few typos on a method name to fix I think.
This allows API restructuing and a clean builder pattern on the new `options` package. Tests have been added to the new package as well, which bumps its test coverage to 100%. Signed-off-by: Sascha Grunert <[email protected]>
Yep, fixed those, thank you! 🙏 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind api-change
/kind cleanup
What this PR does / why we need it:
This allows API restructuing and a clean builder pattern on the new
optionspackage. Tests have been added to the new package as well,which bumps its test coverage to 100%.
Which issue(s) this PR fixes:
Follow-up of #1282
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?