Enhance kubepkg testing #1290
Merged
Enhance kubepkg testing #1290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps the test coverage of kubepkg and separates the test more from the actual implementation. Signed-off-by: Sascha Grunert <[email protected]>
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/release-eng
justaugustus
approved these changes
May 18, 2020
There was a problem hiding this comment.
@saschagrunert -- Small nit, but feel free to fix that in a follow-up.
/lgtm
/approve
| "github.com/pkg/errors" | ||
| "github.com/sirupsen/logrus" | ||
|
|
||
| gogithub "github.com/google/go-github/v29/github" |
There was a problem hiding this comment.
This should be in the above import group.
There was a problem hiding this comment.
Yes, fixed in #1300
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This bumps the test coverage of kubepkg and separates the test more from
the actual implementation.
Which issue(s) this PR fixes:
Follow-up of #1285
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?