kubepkg: Bundle CNI plugins (v0.8.6) in kubelet deb/rpm packages #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/release-eng
k8s-ci-robot
added
size/L
justaugustus
force-pushed
the
cni-update
branch
3 times, most recently
from
5a92478 to
16efa74
Compare
Signed-off-by: Stephen Augustus <[email protected]>
2 tasks
justaugustus
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
lgtm
|
/hold for others to review if needed |
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, hasheddan, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
looks like not needed :) |
k8s-ci-robot
removed
the
do-not-merge/hold
|
|
||
| # TODO: Do we need this? | ||
| #%make_install | ||
|
|
||
| %files | ||
| %{_bindir}/kubelet | ||
| %{_unitdir}/kubelet.service | ||
| %{_sysconfdir}/kubernetes/manifests/ | ||
| /opt/cni |
There was a problem hiding this comment.
As mentioned in #1309 (comment), I think we could discuss a better location than /opt
This was referenced Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup feature
/area dependency
/sig network
What this PR does / why we need it:
Bundle CNI plugins (v0.8.6) in kubelet deb/rpm packages
(Reverse backport... forward port(?) of #1309)
ref: #885, kubernetes/kubernetes#91370
Signed-off-by: Stephen Augustus [email protected]
cc: @kubernetes/release-engineering
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
WIP. There will be some broken tests on this one.
Does this PR introduce a user-facing change?