-
Notifications
You must be signed in to change notification settings - Fork 520
Closed
Labels
area/release-engIssues or PRs related to the Release Engineering subprojectIssues or PRs related to the Release Engineering subprojectkind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.needs-prioritysig/releaseCategorizes an issue or PR as relevant to SIG Release.Categorizes an issue or PR as relevant to SIG Release.
Description
What happened:
While working on #1330, I noticed that kubepkg
doesn't actually respect user-supplied flags, instead running with the defaults specified in pkg/kubepkg/options.go
(options.New()
):
release/pkg/kubepkg/options/options.go
Lines 73 to 82 in d992507
func New() *Options { | |
return &Options{ | |
revision: defaultRevision, | |
packages: supportedPackages, | |
channels: supportedChannels, | |
architectures: supportedArchitectures, | |
releaseDownloadLinkBase: DefaultReleaseDownloadLinkBase, | |
templateDir: latestTemplateDir, | |
} | |
} |
/assign @saschagrunert
Metadata
Metadata
Assignees
Labels
area/release-engIssues or PRs related to the Release Engineering subprojectIssues or PRs related to the Release Engineering subprojectkind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.needs-prioritysig/releaseCategorizes an issue or PR as relevant to SIG Release.Categorizes an issue or PR as relevant to SIG Release.