-
Notifications
You must be signed in to change notification settings - Fork 519
Fix kubepkg options parsing #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The custom options where not working at all before because of the parsing in `init()`. This as been fixed by making the flag vars global and the ad-hoc creation of `options.Options`. Signed-off-by: Sascha Grunert <[email protected]>
Looks good locally:
Thanks for the quick fix! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind regression
What this PR does / why we need it:
The custom options where not working at all before because of the
parsing in
init()
. This as been fixed by making the flag vars globaland the ad-hoc creation of
options.Options
.Which issue(s) this PR fixes:
Fixes #1331
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?