scripts: template json safely

[hasheddan]

Updates anago to template json with jq.

Fixes #853

/cc @justaugustus

[k8s-ci-robot]

Welcome @hasheddan!

It looks like this is your first PR to kubernetes/release 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/release has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

@hasheddan: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.]

• anago

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hasheddan]

/assign @feiskyer

[hoegaarden]

Thanks for your PR!

Ideally we'd test those changes, so that we get a bit more coverage on anago and others, little by little. E.g. I could see the generation of the payload be broken out into a separate function and tests that verify that the payload we generate is always valid json, holds the desired values we template, ... and all that jazz.
I won't block on that, but let me know what you think, about the test and my other comments.

[hasheddan]

@hoegaarden thanks for your review! I have implemented the suggested changes. In regards to the testing, I heard @justaugustus talk a bit about moving some of these scripts to a more formal tool, likely written in Go. It looks like he has started this effort with #869. I would love to jump in on this effort and potentially take a leadership role in the effort to build a release tool that accomplishes what the collection of scrips currently does. That being said, if it is more desirable just to test these existing scripts, I am happy to do that as well :)

[hoegaarden]

@hasheddan

[...] That being said, if it is more desirable just to test these existing scripts, I am happy to do that as well :)

First off: I am definitely not asking you to backfill tests for the entirety of anago :)

[...] In regards to the testing, I heard @justaugustus talk a bit about moving some of these scripts to a more formal tool

Yep, I am aware that there are some efforts going on to replace anago and others with existing and new tools. However, I guess that will still take some time.
So I'd love to get some tests in place for stuff that we change, so that I have some more confidence that the scripts won't break for some other member of the (patch-)release-team after I merge something. Therefore I was suggesting to add some tests around the generation of the payload; we could capture the current payload and check that we generate the same one after our refactor. That would give me way more confidence when reviewing.
But still, I won't block on that. :)

[hoegaarden]

/lgtm
/approve
/assign @justaugustus

[justaugustus]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, hoegaarden, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hoegaarden,justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment