-
Notifications
You must be signed in to change notification settings - Fork 423
Update Release Notes Handbook to remove website PR creation instructions #2342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -179,8 +176,8 @@ To update an entry in this section the following steps must be performed: | |||
### Week 1 | |||
|
|||
Begin running release-notes tool for the ongoing collection of release notes with the first alpha release, which has been cut directly after the latest minor. | |||
- Update the `release-notes-draft.md` | |||
- Update the website |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to verify at least that the notes are available on the website?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good idea. Currently, krel release
publishes artificates to GCS which should instantaneously be picked up by the website. So is this the correct spot to add that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so 👍
/lgtm |
Actually, from a |
That is correct. I have also added a deprecation to the flag |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashnehete, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this:
/kind documentation
What this PR does / why we need it:
This PR removes the sections that instruct members to update kubernetes-sigs/release-notes with new release notes. The process has been automated with kubernetes/release#1087 and is no longer needed in the handbook.
Which issue(s) this PR fixes:
Fixes kubernetes/release#1087
cc @saschagrunert