Skip to content

Conversation

ashnehete
Copy link
Contributor

What type of PR is this:

/kind documentation

What this PR does / why we need it:

This PR removes the sections that instruct members to update kubernetes-sigs/release-notes with new release notes. The process has been automated with kubernetes/release#1087 and is no longer needed in the handbook.

Which issue(s) this PR fixes:

Fixes kubernetes/release#1087

cc @saschagrunert

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Sep 17, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 17, 2023
@@ -179,8 +176,8 @@ To update an entry in this section the following steps must be performed:
### Week 1

Begin running release-notes tool for the ongoing collection of release notes with the first alpha release, which has been cut directly after the latest minor.
- Update the `release-notes-draft.md`
- Update the website
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to verify at least that the notes are available on the website?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea. Currently, krel release publishes artificates to GCS which should instantaneously be picked up by the website. So is this the correct spot to add that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think so 👍

@fsmunoz
Copy link
Contributor

fsmunoz commented Sep 18, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2023
@fsmunoz
Copy link
Contributor

fsmunoz commented Sep 18, 2023

Actually, from a krel perspective and just to be absolutely on the safe side: this means that the krel release-notes --create-website-pr --fix --fork fsmunoz --list-v2 ... command is now not needed, and the --create-draft-pr is enough since the result of it will be picked up by the website?

@ashnehete
Copy link
Contributor Author

Actually, from a krel perspective and just to be absolutely on the safe side: this means that the krel release-notes --create-website-pr --fix --fork fsmunoz --list-v2 ... command is now not needed, and the --create-draft-pr is enough since the result of it will be picked up by the website?

That is correct. I have also added a deprecation to the flag --create-website-pr at kubernetes/release#3277.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashnehete, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 148308f into kubernetes:master Sep 19, 2023
@Priyankasaggu11929 Priyankasaggu11929 added this to the v1.29 milestone Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload release notes JSON (relnotes.k8s.io) to a Google Cloud Bucket
5 participants