Skip to content

Conversation

thockin
Copy link
Member

@thockin thockin commented Jul 1, 2025

Reference KYAML as an available output format

xref kubernetes/enhancements#5295

/cc @lmktfy

@k8s-ci-robot k8s-ci-robot requested a review from lmktfy July 1, 2025 16:43
@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Jul 1, 2025
Copy link

netlify bot commented Jul 1, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 9f26f83
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/68644509fba4b90008d48fcf

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2025
@thockin thockin mentioned this pull request Jul 1, 2025
15 tasks
@lmktfy
Copy link
Contributor

lmktfy commented Jul 1, 2025

Also please rebase against main.

@thockin
Copy link
Member Author

thockin commented Jul 1, 2025

if I rebase against main, I get a bunch of commits that are not in dev-1.34

@lmktfy
Copy link
Contributor

lmktfy commented Jul 1, 2025

D'oh, yes, this is already targeting the correct branch. You will need to rebase against dev-1.34, once #51454 has merged.

@thockin
Copy link
Member Author

thockin commented Jul 1, 2025

Rebased

Copy link

netlify bot commented Jul 1, 2025

Pull request preview available for checking

Name Link
🔨 Latest commit 9f26f83
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6864450909dc960008d2096e
😎 Deploy Preview https://deploy-preview-51462--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM
/approve

Once to the code changes for v1.34 have merged, OK to unhold this.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4f11555f3d6cba80afe915a74fc403e39d5e6abc

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit 48f8ce3 into kubernetes:dev-1.34 Jul 2, 2025
6 checks passed
@lmktfy
Copy link
Contributor

lmktfy commented Jul 2, 2025

I meant to hold this one. We can revert if it merged too early.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants