Skip to content

Init Persian localization - Part 1 #51695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Init Persian localization - Part 1 #51695

wants to merge 1 commit into from

Conversation

xirehat
Copy link
Member

@xirehat xirehat commented Jul 25, 2025

Following the discussions in the sig-docs-localizations Slack channel, I plan to open the first initialization PR for Persian localization after PR(#51598) is closed.

Closes: #47142

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 25, 2025
@xirehat xirehat mentioned this pull request Jul 25, 2025
Open
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jul 25, 2025
lmktfy
lmktfy reviewed Jul 26, 2025
View reviewed changes
content/fa/community/static/README.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note is important!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

lmktfy
lmktfy reviewed Jul 26, 2025
View reviewed changes
content/fa/docs/setup/learning-environment/_index.md
Comment on lines +11 to +12
{{/* If you're localizing this page, you only need to copy the front matter */}}
{{/* and add a redirect into "/static/_redirects", for YOUR localization. */}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

lmktfy
lmktfy reviewed Jul 26, 2025
View reviewed changes
i18n/fa/fa.toml Outdated
@@ -0,0 +1,678 @@
# i18n strings for the English (main) site.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite. This is Persian.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@xirehat xirehat force-pushed the init-persian-localization branch from 6a7e0af to 0209136 Compare July 29, 2025 10:24
@k8s-ci-robot
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing /verify-owners in a comment.

  • behiuu
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
  • mamrezb
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
  • moh0ps
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
  • xirehat
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

@lmktfy
Copy link
Contributor

lmktfy commented Aug 3, 2025

We've merged in support for right-to-left locales!

Could you either:

  • rebase this on top of main
  • (better) pick just a smaller set of the changes within this PR, and open a new PR to propose that subset of changes? The new PR should be based on the very latest main branch at the time you open it.

I think the localization team should be working on getting a new branch for Persian. If that has already happened, the new PR should target a merge into that Persian development branch. If it hasn't, ask the localization sub project to help.

@xirehat
Copy link
Member Author

xirehat commented Aug 13, 2025

I'm going to close this PR so we can create smaller ones, making the review process easier.

See #51801

@xirehat xirehat closed this Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmktfy lmktfy lmktfy left review comments

@natalisucks natalisucks Awaiting requested review from natalisucks

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Localize Kubernetes website into Farsi
3 participants
@xirehat @k8s-ci-robot @lmktfy