Skip to content

Conversation

xirehat
Copy link
Member

@xirehat xirehat commented Aug 4, 2025

Initialize Persian (fa) translation for the Kubernetes website main page.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 4, 2025
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Aug 4, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Aug 4, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a really important file. To get this through, consider only including the strings you are 100% sure of.

The initial build will work (using English strings) even if you miss some out here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has been translated accurately to meet our needs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I've minimized fa.toml to meet main page be rendered.

Copy link
Contributor

@lmktfy lmktfy Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider omitting this change from the initial PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lmktfy
Could you share your idea why you are suggesting omitting the changes hugo.toml ?

I thought the initial PR for this dev branch (not for entire initial works for the first Persian release) needs a minimal foundation that supports netlify preview without build error for the following Persian PRs that focused on localization itself.
I guess without hugo.toml, we may not achieve this. (but, of course, changing any file outside contents/fa/* will increase possibility on merge conflict when we try to merge the dev branch into main branch)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change it soon, but for this first PR, enabling Persian means a CI/CD test failure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Netlify build problem has been resolved, so no changes to Netlify are required. We can achieve the desired outcome by updating hugo.toml and allowing Netlify to complete a successful build
@lmktfy @seokho-son

@@ -0,0 +1,62 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think
content/fa/_index.md should be content/fa/_index.html

considering content/en/_index.html

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link

netlify bot commented Aug 5, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9394706
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68974f913c645700087aabea
😎 Deploy Preview https://deploy-preview-51801--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 5, 2025
i18n/fa/fa.toml Outdated
# NOTE: <current-version> and <current-changelog-url> are placeholders set by 'release-binaries' shortcode.
# Please do not localize or modify <current-version> and <current-changelog-url> placeholders.
[release_binary_section_note]
other = """برای بارگیری نسخه‌های قدیمی‌تر فایل های اصلاح اجزای <نسخه فعلی> کوبرنتیز (و چک‌سام‌های آنها)، لطفاً به فایل [CHANGELOG](https://github.com/kubernetes/kubernetes/tree/master/CHANGELOG/CHANGELOG-<current-changelog-url>.md) مراجعه کنید."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
other = """برای بارگیری نسخه‌های قدیمی‌تر فایل های اصلاح اجزای <نسخه فعلی> کوبرنتیز (و چک‌سام‌های آنها)، لطفاً به فایل [CHANGELOG](https://github.com/kubernetes/kubernetes/tree/master/CHANGELOG/CHANGELOG-<current-changelog-url>.md) مراجعه کنید."""
other = """برای بارگیری نسخه‌های قدیمی‌تر فایل های اصلاح اجزای <current-version> کوبرنتیز (و چک‌سام‌های آنها)، لطفاً به فایل [CHANGELOG](https://github.com/kubernetes/kubernetes/tree/master/CHANGELOG/CHANGELOG-<current-changelog-url>.md) مراجعه کنید."""

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, I removed them and will be insert in correct format in futures PR in Persian localization

i18n/fa/fa.toml Outdated
# NOTE: <current-version> is a placeholder for the actual version number set by 'release-binaries' shortcode.
# Please do not localize or modify <current-version> placeholder.
[release_binary_section]
other = """می‌توانید نشانی های بارگیری اجزای <نسخه فعلی> کوبرنتیز (به همراه چک‌سام‌های آنها) را در زیر بیابید.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
other = """می‌توانید نشانی های بارگیری اجزای <نسخه فعلی> کوبرنتیز (به همراه چک‌سام‌های آنها) را در زیر بیابید.
other = """می‌توانید نشانی های بارگیری اجزای <current-version> کوبرنتیز (به همراه چک‌سام‌های آنها) را در زیر بیابید.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, I removed them and will be insert in correct format in futures PR in Persian localization

## اجرای تارنما با Docker

&#x202b;
برای اجرای تارنما کوبرنتیز، توصیه می‌شود آن را با [Docker](https://docker.com) اجرا کنید که شامل مولد تارنما استاتیک [Hugo](https://gohugo.io) باشد.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
برای اجرای تارنما کوبرنتیز، توصیه می‌شود آن را با [Docker](https://docker.com) اجرا کنید که شامل مولد تارنما استاتیک [Hugo](https://gohugo.io) باشد.
برای اجرای تارنما کوبرنتیز، توصیه می‌شود آن را با [داکر](https://docker.com) اجرا کنید که شامل مولد تارنما ایستا [هوگو](https://gohugo.io) باشد.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s better not to translate software names into Persian. but I agree to use ایستا‍ instead of ‍‍استاتیک

> اگر ترجیح می‌دهید تارنما را بدون داکر اجرا کنید، به [اجرای تارنما با هوگو](#اجرای-تارنما-با-هوگو) مراجعه کنید.
&#x202b;
قالب مورد نیاز [Docsy Hugo theme](https://github.com/google/docsy#readme) باید به عنوان یک زیرماژول git نصب شود:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
قالب مورد نیاز [Docsy Hugo theme](https://github.com/google/docsy#readme) باید به عنوان یک زیرماژول git نصب شود:
قالب مورد نیاز [Docsy Hugo theme](https://github.com/google/docsy#readme) باید به عنوان یک زیرسیستم گیت نصب شود:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s better not to translate software names into Persian. in this place it should be زیر ماژول

```

&#x202b;
برای مشاهده تارنما، مرورگر خود را با نشانی http://localhost:1313 باز کنید. وقتی تغییراتی در پرونده‌های منبع ایجاد می‌کنید، Hugo تارنما را به‌روزرسانی کرده و مرورگر را مجبور به فراخوانی مجدد می‌کند.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
برای مشاهده تارنما، مرورگر خود را با نشانی http://localhost:1313 باز کنید. وقتی تغییراتی در پرونده‌های منبع ایجاد می‌کنید، Hugo تارنما را به‌روزرسانی کرده و مرورگر را مجبور به فراخوانی مجدد می‌کند.
برای مشاهده تارنما، مرورگر خود را با نشانی http://localhost:1313 باز کنید. وقتی تغییراتی در پرونده‌های منبع ایجاد می‌کنید، هوگو تارنما را به‌روزرسانی کرده و مرورگر را مجبور به فراخوانی مجدد می‌کند.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s better not to translate software names into Persian.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s better not to translate software names into Persian.

So please correct the other parts you translated into Persian as well.If you want, I can help you find those sections.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

## اجرای تارنما با هوگو

&#x202b;
دستورالعمل‌های نصب Hugo را می‌توانید در [مستندات رسمی](https://gohugo.io/installation/) بیابید. مطمئن شوید که نسخه Hugo مشخص شده در متغیر محیطی `HUGO_VERSION` در فایل `netlify.toml` را نصب می‌کنید.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
دستورالعمل‌های نصب Hugo را می‌توانید در [مستندات رسمی](https://gohugo.io/installation/) بیابید. مطمئن شوید که نسخه Hugo مشخص شده در متغیر محیطی `HUGO_VERSION` در فایل `netlify.toml` را نصب می‌کنید.
دستورالعمل‌های نصب هوگو را می‌توانید در [مستندات رسمی](https://gohugo.io/installation/) بیابید. مطمئن شوید که نسخه هوگو مشخص شده در متغیر محیطی `HUGO_VERSION` در پرونده `netlify.toml` را نصب می‌کنید.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s better not to translate software names into Persian. but I agree to use پرونده instead of ‍‍فایل

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s better not to translate software names into Persian. but I agree to use پرونده instead of ‍‍فایل

So please correct the other parts you translated into Persian as well.If you want, I can help you find those sections.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

دستورالعمل‌های نصب Hugo را می‌توانید در [مستندات رسمی](https://gohugo.io/installation/) بیابید. مطمئن شوید که نسخه Hugo مشخص شده در متغیر محیطی `HUGO_VERSION` در فایل `netlify.toml` را نصب می‌کنید.

&#x202b;
قالب مورد نیاز [Docsy Hugo theme](https://github.com/google/docsy#readme) باید به عنوان یک زیرماژول git نصب شود:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
قالب مورد نیاز [Docsy Hugo theme](https://github.com/google/docsy#readme) باید به عنوان یک زیرماژول git نصب شود:
قالب مورد نیاز [Docsy Hugo theme](https://github.com/google/docsy#readme) باید به عنوان یک زیرسیستم گیت نصب شود:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s better not to translate software names into Persian. in this place it should be زیر ماژول


{{< blocks/section id="video" background-image="kub_video_banner_homepage" >}}
<div class="light-text">
<h2>چالش‌های مهاجرت بیش از ۱۵۰ میکروسرویس به کوبرنتیز</h2>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h2>چالش‌های مهاجرت بیش از ۱۵۰ میکروسرویس به کوبرنتیز</h2>
<h2>چالش‌های مهاجرت بیش از ۱۵۰ ریز خدمت به کوبرنتیز</h2>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Persian docs it's not regular to use ریز خدمت, it should be kept میکروسرویس

* [کانال Slack](https://kubernetes.slack.com/messages/kubernetes-docs-fa)

&#x202b;
## اجرای تارنما با Docker
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## اجرای تارنما با Docker
## اجرای تارنما با داکر

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s better not to translate software names into Persian.

xirehat added a commit to xirehat/website that referenced this pull request Aug 6, 2025
based on @lmktfy suggesstion: kubernetes#51801 (comment)

Co-authored-by: Mohammad Zarei <[email protected]>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 6, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 6, 2025
@Moh0ps
Copy link

Moh0ps commented Aug 6, 2025

/lgtm

@k8s-ci-robot
Copy link
Contributor

@Moh0ps: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xirehat,

I think the content and review progress of this PR look great.
except some minor issues. (PTAL the comments)

Would you mind removing ./README.md from this PR as well? Without the ./README.md file, we can stay focused on the following two directories for the current development branch:

  • content/fa
  • i18n/fa

This will help minimize any potential conflicts when we eventually apply kubernetes:dev-1.33-fa.1 to the main branch.

FYI: Later on, we can update the development branch via
dev-1.33-fa.1...main
and merge it into main via
main...dev-1.33-fa.1
(If there are no merge conflicts, the process will be straightforward.)

The ./README.md file and any other files needed for the Persian localization can be added during the final stage of the initial Persian release. 🙂

After that, to finalize this PR, please squash commits of this PR into one commit.

Thanks!

# Localization note (no need to translate this note)
# This is always followed by Chinese text, as required by the Kubernetes
# project's ICP license, issued by the government of the People's Republic
# of China.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are these texts from?
I don't think they are needed.


Also, please try to use and reference the files in https://github.com/kubernetes/website/tree/dev-1.33-fa.1/content/en from the dev-1.33-fa.1 branch as the base for localization as much as possible.

Note that your PR's feature branch needs to be based on dev-1.33-fa.1.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These text are from i18n/en/en.toml, I think it should be there.
In future PR we will follow up your suggestion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's here(

# Localization note (no need to translate this note)
)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seokho-son squashing also is done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xirehat oh, thanks for the clarification. :) lgtm

README.md Outdated
| [Italian](./content/it/README.md) | [Vietnamese](./content/vi/README.md) |
| [Japanese](./content/ja/README.md) | |

| [Bengali](./content/bn/README.md) | [Korean](./content/ko/README.md) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about not changing this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, reverted

@seokho-son
Copy link
Member

/assign @seokho-son

@seokho-son
Copy link
Member

seokho-son commented Aug 7, 2025

Hi @mamrezb you don't need to use Request changes when you leave a review to a PR. Comment is enough :)
Could you check your review has been addressed in this PR already?

@seokho-son
Copy link
Member

https://deploy-preview-51801--kubernetes-io-main-staging.netlify.app/fa/

/lgtm

I think it is a good foundation for the upcoming Persian localization contributions (translating technical documents) :)

To make it sure, @lmktfy do you have any concern on this PR?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b2c36f4d66b5c745b4255c6ac67aaf786eeccdd3

@lmktfy
Copy link
Contributor

lmktfy commented Aug 7, 2025

There is one thing I spotted. It's significant, I think, and needs highlighting—but it needn't prevent merging this PR.

The problem is that the LTR layout positions one element outside the viewport. See

<div style="position: absolute; left: -5000px;" aria-hidden="true"><input type="text" name="b_3885586f8f1175194017967d6_11c1b8bcb2" tabindex="-1" value=""></div>

The trouble with RTL locales is that this element is no longer outside the viewport, and you may even be able to scroll to it.

For either this, or a follow up PR, we ought to fix that. Now, I have some related work in progress – see PR #50665 – and I am happy to pull out a fix for this one part, myself.

But I want to highlight it. First, folks need to check some PRs, this included, using a tablet / mobile device or a simulator. Second, watch out for stale assumptions about LTR-only content.


How do we want to proceed?

@mamrezb
Copy link
Contributor

mamrezb commented Aug 7, 2025

Hi @mamrezb you don't need to use Request changes when you leave a review to a PR. Comment is enough :) Could you check your review has been addressed in this PR already?

Hi @seokho-son, Thanks for the reminder about review states :) Could you clarify the guideline on when to use Request changes versus a regular comment? I used it because the text I flagged was crucial, but I’m happy to follow the best practice going forward.

Hi @mamrezb

In my understanding, across Kubernetes GitHub repositories, we generally lean on prow commands instead of relying heavily on the GitHub GUI (using those buttons such as applying Commit suggestion, Request changes, Merge pull request, ...). 🙂

For example, if you think something is critical and should block merging, you can use the /hold command. But for general review feedback or suggestions, simply leaving a review with Comment is usually sufficient.

Ultimately, someone with the authority to /approve the PR will give it a final review before merging, and they’ll make the call on whether everything looks good.

If a reviewer uses Request changes and doesn’t clear it after the author addresses the feedback, it can unintentionally block the PR from merging — which is why we try to avoid using that unless absolutely necessary.

That said, this is based on conventions I’ve observed from contributing to the project over the past few years — I’m not sure there’s a strict written guideline on this. 😅

Thanks again for your thoughtful review!

k8s-ci-robot
The full list of commands accepted by this bot can be found here.

Thanks for the detailed explanation @seokho-son. That makes sense.
I’ll stick to regular comments and commands for feedbacks and reviews going forward.
Appreciate the guidance!

@lmktfy
Copy link
Contributor

lmktfy commented Aug 7, 2025

There's a problem that shows up on small viewports (tablet / mobile), if you scroll to the left.

<div style="position: absolute; left: -5000px;" aria-hidden="true"><input type="text" name="b_3885586f8f1175194017967d6_11c1b8bcb2" tabindex="-1" value=""></div>
does some absolute positioning to the left (to hide an element): it's a bodge that assumes a left-to-right writing system.

We ought to plan how we'll fix that. As our own quick fix (“bodge”), we can adapt left in the shortcode to right based on the current writing direction.

Would anyone like to:

  • work on that quick fix?
  • file an issue about cleaning it up even more?

Although I spotted a snag, I am happy for this PR to merge. I do think there's a story to tell about checking Persian PRs, especially the first few, with different viewport sizes.

@seokho-son
Copy link
Member

seokho-son commented Aug 7, 2025

Thanks for checking! @lmktfy — you're always amazing!

As long as we (contributors involved in the Persian localization release) reach a mutual consensus on the next steps, I think this PR is good to be merged.

  1. This PR builds without errors and the preview works fine on desktop, so I think it's sufficient as an initial step and can be merged into the dev-1.33-fa.1 branch (noting that there are some mobile view issues to address later).

  2. After that, Persian contributors can continue localizing content mainly under content/fa/*.
    (Note: In general, there's no need to copy English files unless necessary. Only localized files should be included in the commits. However, if specific English files or content are needed to make the build pass, it's okay to include them.)

    • Since we currently have a limited number of contributors, I suggest assigning localization parts through mutual agreement.
    • At first, each contributor needs to submit only one localized content file per PR. This is to help everyone become familiar with the contribution flow and reduce errors. (please try to use and reference the files in https://github.com/kubernetes/website/tree/dev-1.33-fa.1/content/en from the dev-1.33-fa.1 branch as the base for localization as much as possible. Note that your PR's feature branch needs to be based on dev-1.33-fa.1 not on main.)
    • Later on, it's totally fine to include more localized files in a single PR, as long as it's still within a reasonable scope for human reviewers. Please also avoid submitting too many PRs at once to the repo.
    • We'll keep repeating this localization cycle via PRs until we meet at least the minimal requirements.

Meanwhile, any web-related issues like RTL rendering needs to be resolved in the main branch. Once fixed, those commits can be reflected back into the dev-1.33-fa.1 branch via upstream PRs.

Once all the Persian pages work properly on the dev-1.33-fa.1 branch (including mobile view), and the team meets the minimum requirements with a satisfactory result (as reviewed by the team and i18n subproject leads), we can then move forward with merging it into main.

@seokho-son
Copy link
Member

PTAL above comment. @xirehat , and let us know if you or team members have other opinions. :)
Please share the tentative road map to the contributors.

@xirehat
Copy link
Member Author

xirehat commented Aug 9, 2025

There's a problem that shows up on small viewports (tablet / mobile), if you scroll to the left.

<div style="position: absolute; left: -5000px;" aria-hidden="true"><input type="text" name="b_3885586f8f1175194017967d6_11c1b8bcb2" tabindex="-1" value=""></div>

does some absolute positioning to the left (to hide an element): it's a bodge that assumes a left-to-right writing system.

We ought to plan how we'll fix that. As our own quick fix (“bodge”), we can adapt left in the shortcode to right based on the current writing direction.

Would anyone like to:

* work on that quick fix?

* file an issue about cleaning it up even more?

Although I spotted a snag, I am happy for this PR to merge. I do think there's a story to tell about checking Persian PRs, especially the first few, with different viewport sizes.

@lmktfy I noticed that the scroll issue is addressed in this PR (#51600) in both assets/scss/_desktop.scss and assets/scss/_tablet.scss with the following configuration:

  body:dir(rtl) {
    overflow-x: hidden;
  }

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2025
@k8s-ci-robot k8s-ci-robot requested a review from seokho-son August 9, 2025 13:38
fix: `links` translation

Co-authored-by: Mohammad Zarei <[email protected]>

fix: Persian improvment

Co-authored-by: Mohammad Zarei <[email protected]>

fix: revert software name

fix: translate license to Persian

fix: netlify build error and add hugo.toml

fix: revert README.md

fix: fa.toml main comment

Co-authored-by: Tim Bannister <[email protected]>
@xirehat
Copy link
Member Author

xirehat commented Aug 9, 2025

The last suggestion from @lmktfy has also been addressed. We now just need a final review and the lgtm label.

@seokho-son I think we’re in a good place, and this PR is ready to merge. I also share your opinion about the roadmap, let’s keep building this localization 🚀

@seokho-son
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fb4e9da6e1b752597293238be71308a4a328f81d

@seokho-son
Copy link
Member

/approve

@seokho-son
Copy link
Member

seokho-son commented Aug 9, 2025

Hi @natalisucks,

Could you help the team by approving this PR? I don’t have ownership rights for approval.
I think it would be beneficial if localization subproject leads had approval permissions (not for the review) for cases like this localization initiation. :)

In any case, this PR has already passed the review process and just needs official approval now.
Thanks!

@natalisucks
Copy link
Contributor

thanks for tagging me @seokho-son – happy to approve!
i'd like to chat to the other SIG Docs leads about localization subproject leads having approval permissions for instances like this, so let me get back to you on this point
congratulations to the Persian team!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks, seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9b18430 into kubernetes:dev-1.33-fa.1 Aug 10, 2025
6 checks passed
@xirehat
Copy link
Member Author

xirehat commented Sep 28, 2025

/language fa

@k8s-ci-robot k8s-ci-robot added the language/fa Issues or PRs related to Persian language label Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/fa Issues or PRs related to Persian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants