-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[fa] Init Persian main page #51801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fa] Init Persian main page #51801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually a really important file. To get this through, consider only including the strings you are 100% sure of.
The initial build will work (using English strings) even if you miss some out here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has been translated accurately to meet our needs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I've minimized fa.toml
to meet main page be rendered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider omitting this change from the initial PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lmktfy
Could you share your idea why you are suggesting omitting the changes hugo.toml ?
I thought the initial PR for this dev branch (not for entire initial works for the first Persian release) needs a minimal foundation that supports netlify preview without build error for the following Persian PRs that focused on localization itself.
I guess without hugo.toml, we may not achieve this. (but, of course, changing any file outside contents/fa/* will increase possibility on merge conflict when we try to merge the dev branch into main branch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change it soon, but for this first PR, enabling Persian means a CI/CD test failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Netlify build problem has been resolved, so no changes to Netlify are required. We can achieve the desired outcome by updating hugo.toml
and allowing Netlify to complete a successful build
@lmktfy @seokho-son
@@ -0,0 +1,62 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
content/fa/_index.md should be content/fa/_index.html
considering content/en/_index.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
i18n/fa/fa.toml
Outdated
# NOTE: <current-version> and <current-changelog-url> are placeholders set by 'release-binaries' shortcode. | ||
# Please do not localize or modify <current-version> and <current-changelog-url> placeholders. | ||
[release_binary_section_note] | ||
other = """برای بارگیری نسخههای قدیمیتر فایل های اصلاح اجزای <نسخه فعلی> کوبرنتیز (و چکسامهای آنها)، لطفاً به فایل [CHANGELOG](https://github.com/kubernetes/kubernetes/tree/master/CHANGELOG/CHANGELOG-<current-changelog-url>.md) مراجعه کنید.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other = """برای بارگیری نسخههای قدیمیتر فایل های اصلاح اجزای <نسخه فعلی> کوبرنتیز (و چکسامهای آنها)، لطفاً به فایل [CHANGELOG](https://github.com/kubernetes/kubernetes/tree/master/CHANGELOG/CHANGELOG-<current-changelog-url>.md) مراجعه کنید.""" | |
other = """برای بارگیری نسخههای قدیمیتر فایل های اصلاح اجزای <current-version> کوبرنتیز (و چکسامهای آنها)، لطفاً به فایل [CHANGELOG](https://github.com/kubernetes/kubernetes/tree/master/CHANGELOG/CHANGELOG-<current-changelog-url>.md) مراجعه کنید.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, I removed them and will be insert in correct format in futures PR in Persian localization
i18n/fa/fa.toml
Outdated
# NOTE: <current-version> is a placeholder for the actual version number set by 'release-binaries' shortcode. | ||
# Please do not localize or modify <current-version> placeholder. | ||
[release_binary_section] | ||
other = """میتوانید نشانی های بارگیری اجزای <نسخه فعلی> کوبرنتیز (به همراه چکسامهای آنها) را در زیر بیابید. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other = """میتوانید نشانی های بارگیری اجزای <نسخه فعلی> کوبرنتیز (به همراه چکسامهای آنها) را در زیر بیابید. | |
other = """میتوانید نشانی های بارگیری اجزای <current-version> کوبرنتیز (به همراه چکسامهای آنها) را در زیر بیابید. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, I removed them and will be insert in correct format in futures PR in Persian localization
## اجرای تارنما با Docker | ||
|
||
‫ | ||
برای اجرای تارنما کوبرنتیز، توصیه میشود آن را با [Docker](https://docker.com) اجرا کنید که شامل مولد تارنما استاتیک [Hugo](https://gohugo.io) باشد. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
برای اجرای تارنما کوبرنتیز، توصیه میشود آن را با [Docker](https://docker.com) اجرا کنید که شامل مولد تارنما استاتیک [Hugo](https://gohugo.io) باشد. | |
برای اجرای تارنما کوبرنتیز، توصیه میشود آن را با [داکر](https://docker.com) اجرا کنید که شامل مولد تارنما ایستا [هوگو](https://gohugo.io) باشد. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s better not to translate software names into Persian. but I agree to use ایستا
instead of استاتیک
> اگر ترجیح میدهید تارنما را بدون داکر اجرا کنید، به [اجرای تارنما با هوگو](#اجرای-تارنما-با-هوگو) مراجعه کنید. | ||
‫ | ||
قالب مورد نیاز [Docsy Hugo theme](https://github.com/google/docsy#readme) باید به عنوان یک زیرماژول git نصب شود: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
قالب مورد نیاز [Docsy Hugo theme](https://github.com/google/docsy#readme) باید به عنوان یک زیرماژول git نصب شود: | |
قالب مورد نیاز [Docsy Hugo theme](https://github.com/google/docsy#readme) باید به عنوان یک زیرسیستم گیت نصب شود: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s better not to translate software names into Persian. in this place it should be زیر ماژول
``` | ||
|
||
‫ | ||
برای مشاهده تارنما، مرورگر خود را با نشانی http://localhost:1313 باز کنید. وقتی تغییراتی در پروندههای منبع ایجاد میکنید، Hugo تارنما را بهروزرسانی کرده و مرورگر را مجبور به فراخوانی مجدد میکند. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
برای مشاهده تارنما، مرورگر خود را با نشانی http://localhost:1313 باز کنید. وقتی تغییراتی در پروندههای منبع ایجاد میکنید، Hugo تارنما را بهروزرسانی کرده و مرورگر را مجبور به فراخوانی مجدد میکند. | |
برای مشاهده تارنما، مرورگر خود را با نشانی http://localhost:1313 باز کنید. وقتی تغییراتی در پروندههای منبع ایجاد میکنید، هوگو تارنما را بهروزرسانی کرده و مرورگر را مجبور به فراخوانی مجدد میکند. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s better not to translate software names into Persian.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s better not to translate software names into Persian.
So please correct the other parts you translated into Persian as well.If you want, I can help you find those sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
## اجرای تارنما با هوگو | ||
|
||
‫ | ||
دستورالعملهای نصب Hugo را میتوانید در [مستندات رسمی](https://gohugo.io/installation/) بیابید. مطمئن شوید که نسخه Hugo مشخص شده در متغیر محیطی `HUGO_VERSION` در فایل `netlify.toml` را نصب میکنید. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
دستورالعملهای نصب Hugo را میتوانید در [مستندات رسمی](https://gohugo.io/installation/) بیابید. مطمئن شوید که نسخه Hugo مشخص شده در متغیر محیطی `HUGO_VERSION` در فایل `netlify.toml` را نصب میکنید. | |
دستورالعملهای نصب هوگو را میتوانید در [مستندات رسمی](https://gohugo.io/installation/) بیابید. مطمئن شوید که نسخه هوگو مشخص شده در متغیر محیطی `HUGO_VERSION` در پرونده `netlify.toml` را نصب میکنید. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s better not to translate software names into Persian. but I agree to use پرونده
instead of فایل
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s better not to translate software names into Persian. but I agree to use
پرونده
instead of فایل
So please correct the other parts you translated into Persian as well.If you want, I can help you find those sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
دستورالعملهای نصب Hugo را میتوانید در [مستندات رسمی](https://gohugo.io/installation/) بیابید. مطمئن شوید که نسخه Hugo مشخص شده در متغیر محیطی `HUGO_VERSION` در فایل `netlify.toml` را نصب میکنید. | ||
|
||
‫ | ||
قالب مورد نیاز [Docsy Hugo theme](https://github.com/google/docsy#readme) باید به عنوان یک زیرماژول git نصب شود: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
قالب مورد نیاز [Docsy Hugo theme](https://github.com/google/docsy#readme) باید به عنوان یک زیرماژول git نصب شود: | |
قالب مورد نیاز [Docsy Hugo theme](https://github.com/google/docsy#readme) باید به عنوان یک زیرسیستم گیت نصب شود: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s better not to translate software names into Persian. in this place it should be زیر ماژول
|
||
{{< blocks/section id="video" background-image="kub_video_banner_homepage" >}} | ||
<div class="light-text"> | ||
<h2>چالشهای مهاجرت بیش از ۱۵۰ میکروسرویس به کوبرنتیز</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<h2>چالشهای مهاجرت بیش از ۱۵۰ میکروسرویس به کوبرنتیز</h2> | |
<h2>چالشهای مهاجرت بیش از ۱۵۰ ریز خدمت به کوبرنتیز</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Persian docs it's not regular to use ریز خدمت
, it should be kept میکروسرویس
* [کانال Slack](https://kubernetes.slack.com/messages/kubernetes-docs-fa) | ||
|
||
‫ | ||
## اجرای تارنما با Docker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## اجرای تارنما با Docker | |
## اجرای تارنما با داکر |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s better not to translate software names into Persian.
based on @lmktfy suggesstion: kubernetes#51801 (comment) Co-authored-by: Mohammad Zarei <[email protected]>
/lgtm |
@Moh0ps: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @xirehat,
I think the content and review progress of this PR look great.
except some minor issues. (PTAL the comments)
Would you mind removing ./README.md from this PR as well? Without the ./README.md file, we can stay focused on the following two directories for the current development branch:
- content/fa
- i18n/fa
This will help minimize any potential conflicts when we eventually apply kubernetes:dev-1.33-fa.1 to the main branch.
FYI: Later on, we can update the development branch via
dev-1.33-fa.1...main
and merge it into main via
main...dev-1.33-fa.1
(If there are no merge conflicts, the process will be straightforward.)
The ./README.md file and any other files needed for the Persian localization can be added during the final stage of the initial Persian release. 🙂
After that, to finalize this PR, please squash commits of this PR into one commit.
Thanks!
# Localization note (no need to translate this note) | ||
# This is always followed by Chinese text, as required by the Kubernetes | ||
# project's ICP license, issued by the government of the People's Republic | ||
# of China. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are these texts from?
I don't think they are needed.
Also, please try to use and reference the files in https://github.com/kubernetes/website/tree/dev-1.33-fa.1/content/en from the dev-1.33-fa.1 branch as the base for localization as much as possible.
Note that your PR's feature branch needs to be based on dev-1.33-fa.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These text are from i18n/en/en.toml
, I think it should be there.
In future PR we will follow up your suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's here(
Line 33 in 8fd2b28
# Localization note (no need to translate this note) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seokho-son squashing also is done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xirehat oh, thanks for the clarification. :) lgtm
README.md
Outdated
| [Italian](./content/it/README.md) | [Vietnamese](./content/vi/README.md) | | ||
| [Japanese](./content/ja/README.md) | | | ||
|
||
| [Bengali](./content/bn/README.md) | [Korean](./content/ko/README.md) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about not changing this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, reverted
/assign @seokho-son |
Hi @mamrezb you don't need to use |
https://deploy-preview-51801--kubernetes-io-main-staging.netlify.app/fa/ /lgtm I think it is a good foundation for the upcoming Persian localization contributions (translating technical documents) :) To make it sure, @lmktfy do you have any concern on this PR? |
LGTM label has been added. Git tree hash: b2c36f4d66b5c745b4255c6ac67aaf786eeccdd3
|
There is one thing I spotted. It's significant, I think, and needs highlighting—but it needn't prevent merging this PR. The problem is that the LTR layout positions one element outside the viewport. See Line 25 in cfa9a06
The trouble with RTL locales is that this element is no longer outside the viewport, and you may even be able to scroll to it. For either this, or a follow up PR, we ought to fix that. Now, I have some related work in progress – see PR #50665 – and I am happy to pull out a fix for this one part, myself. But I want to highlight it. First, folks need to check some PRs, this included, using a tablet / mobile device or a simulator. Second, watch out for stale assumptions about LTR-only content. How do we want to proceed? |
Thanks for the detailed explanation @seokho-son. That makes sense. |
There's a problem that shows up on small viewports (tablet / mobile), if you scroll to the left.
We ought to plan how we'll fix that. As our own quick fix (“bodge”), we can adapt Would anyone like to:
Although I spotted a snag, I am happy for this PR to merge. I do think there's a story to tell about checking Persian PRs, especially the first few, with different viewport sizes. |
Thanks for checking! @lmktfy — you're always amazing! As long as we (contributors involved in the Persian localization release) reach a mutual consensus on the next steps, I think this PR is good to be merged.
Meanwhile, any web-related issues like RTL rendering needs to be resolved in the Once all the Persian pages work properly on the |
PTAL above comment. @xirehat , and let us know if you or team members have other opinions. :) |
@lmktfy I noticed that the scroll issue is addressed in this PR (#51600) in both
|
fix: `links` translation Co-authored-by: Mohammad Zarei <[email protected]> fix: Persian improvment Co-authored-by: Mohammad Zarei <[email protected]> fix: revert software name fix: translate license to Persian fix: netlify build error and add hugo.toml fix: revert README.md fix: fa.toml main comment Co-authored-by: Tim Bannister <[email protected]>
The last suggestion from @lmktfy has also been addressed. We now just need a final review and the lgtm label. @seokho-son I think we’re in a good place, and this PR is ready to merge. I also share your opinion about the roadmap, let’s keep building this localization 🚀 |
/lgtm |
LGTM label has been added. Git tree hash: fb4e9da6e1b752597293238be71308a4a328f81d
|
/approve |
Hi @natalisucks, Could you help the team by approving this PR? I don’t have ownership rights for approval. In any case, this PR has already passed the review process and just needs official approval now. |
thanks for tagging me @seokho-son – happy to approve! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natalisucks, seokho-son The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/language fa |
Initialize Persian (fa) translation for the Kubernetes website main page.