Use provider methods instead of model for 2FA #318
Closed
+6
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Current 2FA validation ignores custom authentication providers. When there's a provider defined that extends
Illuminate\Auth\EloquentUserProvider
with a custom query innewModelQuery
method, it is ignored and instead, user search is done by calling on models, so it bypassesnewModelQuery
method.Steps To Reproduce:
Illuminate\Auth\EloquentUserProvider
.newModelQuery
method and add to query something that would certainly not return a user, like\Laravel\Fortify\Actions\RedirectIfTwoFactorAuthenticatable::validateCredentials
will still find the user and will try to validate credentials.