[1.x] fix: 🐛 Retrieve through UserProvider as possible

[mpyw]

Overview

The related changes have been previously reverted, but we see no problem in merging these changes now.

• [1.x] Retrieve user through provider #189 by @driesvints (merged and reverted by @taylorotwell)
• Use provider methods instead of model for 2FA #318 by @makstech (closed by @driesvints)

Description

• The original PR [1.x] Retrieve user through provider #189 by @driesvints might have some bugs. I mentioned here.

  The verification might be not enough. retrieveByCredentials() does not expect password matches, only an email address does. Password hash validation is done by validateCredentials(), but its call was not included in the PR.

  I think it is the cause of the PR reverted.

  @taylorotwell Is it right?

  Although no reason was given in the PR and commits, it might have lead to the revert.

• Re-created PR Use provider methods instead of model for 2FA #318 by @makstech is looks good to me, but @driesvints appears to have closed it for unknown reasons.

• We've got stuck at Support for Fortify mpyw/scoped-auth#23 because of this, so I decided to re-re-create this PR with detailed explanations.

[pindab0ter]

Looking forward to seeing this functionality restored!

[driesvints]

We are not considering providers other than Eloquent at this time.

[mpyw]

@driesvints I'm still considering using only Eloquent. Our goal is scoping Eloquent Models only for authentication. The scoping logic is implemented under extended EloquentUserProvider.

https://github.com/mpyw/scoped-auth/blob/647cc072644b22cba719e1985c5c83a6470af8da/src/ScopedEloquentUserProvider.php

[taylorotwell]

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

[mpyw]

Merged as #582