merge from master #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
lcxfs1991
commented
Apr 28, 2017
lcxfs1991
commented
- Read and sign the CLA. This needs to be done only once. PRs that haven't signed it won't be accepted.
- Make sure your PR complies with the writer's guide.
- Read through the PR diff carefully as sometimes this can reveal issues. The work will be reviewed, but this can save some effort.
- Remove these instructions from your PR as they are for your eyes only.
…on (e.g. plugins/loaders) Break page links out to their own component to isolate the logic and styling a bit. Remove icons as their alignment and weights are a bit off. This should likely be re-visited later on as they would look better with some nice icons. Resolves #1107
Clarify, reword, and simplify various bits of the production-build guide to make things clearer for future readers. Also add a link to the webpack merge tool for further reading. Fixes #1100
This change is somewhat opinionated as it imposes a fixed width however I don't really see a better solution for displaying these consistently between pages. Also resolves an issue with the gitter button lying on top of the final contributor.
Added a warning instead that points to the v2 version in which this option became obsolete. We could also reference an older version of the docs if necessary for people to jump back to, though that may be overkill. Fixes #1150
Added some info about a pitfall mentioned in webpack/webpack#4771 which is good to keep in mind until the issue is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.