Skip to content

Guides(migrating/#complex-options): remove ident #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michael-ciniawsky opened this issue Apr 24, 2017 · 4 comments
Closed

Guides(migrating/#complex-options): remove ident #1150

michael-ciniawsky opened this issue Apr 24, 2017 · 4 comments
Assignees
@skipjack
Labels
Correction

Comments

@michael-ciniawsky
Copy link
Member

The ident (Complex Options) is obsolete since webpack >= v2.2.1 and gets automatically added internally by webpack
@michael-ciniawsky michael-ciniawsky changed the title refactor(guides/migrating/#complex-options): remove ident Guides(migrating/#complex-options): remove ident Apr 24, 2017
@skipjack
Copy link
Collaborator

skipjack commented Apr 24, 2017 •
edited
Loading

@michael-ciniawsky were you planning to PR this? If not, I'd be happy to but can you give me a rough idea of your thoughts on how to correct this?

Maybe adding a tip (e.g. T> ...) that mentions it was removed? Or just blow away everything about ident as anyone who is migrating now should be jumping to the latest version?

@michael-ciniawsky
Copy link
Member Author

Go ahead if you have time 😛 I'm not sure what's best, imho remove it enterily from the docs :D

@skipjack
Copy link
Collaborator

Sounds good, I'll tackle it soon if no one beats me to it.

@skipjack skipjack self-assigned this Apr 24, 2017
@michael-ciniawsky
Copy link
Member Author

Thx

skipjack added a commit that referenced this issue Apr 25, 2017
@skipjack
fix(guides): remove ident section from the migration guide
9b81d76 
Added a warning instead that points to the v2 version in which this option
became obsolete. We could also reference an older version of the docs if
necessary for people to jump back to, though that may be overkill.

Fixes #1150
@skipjack skipjack mentioned this issue Apr 25, 2017
Merged
rouzbeh84 added a commit to rouzbeh84/webpack.js.org that referenced this issue Apr 26, 2017
@rouzbeh84
update Complex Options ident block per webpack#1150
7f1c93a 
removing info past new `T>...` about `ident` as anyone looking to migrate from this point on should be on webpack >= v2.2.1 but leaving the tip just to clarify for any curious during migration.

thoughts @michael-ciniawsky & @skipjack?
@rouzbeh84 rouzbeh84 mentioned this issue Apr 26, 2017
Closed
skipjack added a commit that referenced this issue Apr 26, 2017
@skipjack
fix(guides): remove ident section from the migration guide
0904eb1 
Added a warning instead that points to the v2 version in which this option
became obsolete. We could also reference an older version of the docs if
necessary for people to jump back to, though that may be overkill.

Fixes #1150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skipjack skipjack

Labels
Correction
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michael-ciniawsky @skipjack