Skip to content

[Remove Vuetify from Studio] Remove unused :v-deep styles from info modal #5095

@MisRob

Description

@MisRob
Member

🙂 Looking for an issue? Welcome! This issue is open for contribution. If this is the first time you’re requesting an issue, please:

  • Read Contributing guidelines carefully. Pay extra attention to Using generative AI. Pull requests and comments that don’t follow the guidelines won’t be answered.
  • Confirm that you’ve read the guidelines in your comment.

Sub-issue of #5060.

Complexity: Low

Summary

Some of these :v-deep styles in shared/views/InfoModal seem to never be used:

::v-deep p {
font-size: 12pt;
line-height: normal;
color: var(--v-grey-darken3);
}

Image

Remove all styles that don't take any effect from here. This will also remove dependency on Vuetify color variable.

InfoModal is used from more locations in the app. One way to preview this is 'About licenses' modal in Settings > Storage > Request more space.

How to get there

  • Login as user@a.com with password a
  • Go to Settings > Storage > Request more space
  • Click Open form
  • Click on info button next to Who can use your content? (Note that button click is broken, fix here. Before the fix is released, temporarily modify code in InfoModal to make the modal visible.)

Guidance

Out of Scope

  • Do not refactor any other areas of the codebase

Expected UI/UX changes

  • None

Acceptance criteria

  • The specification above is followed.
    All user interactions are manually tested with no regressions.
    There are no visual differences.

Activity

vtushar06

vtushar06 commented on Jun 15, 2025

@vtushar06
Contributor

Hi @MisRob 👋
I’m interested in contributing to this issue. I’ve gone through the contributing guidelines and understand the scope and requirements. Could you please confirm if this issue is valid for me to start contributing and be considered for involvement in the organization? Looking forward to your response. Thanks!

@vtushar06

MisRob

MisRob commented on Jun 16, 2025

@MisRob
MemberAuthor

Welcome @vtushar06, thank you! Yes, this is a good issue to start with. I will assign you.

vtushar06

vtushar06 commented on Jun 16, 2025

@vtushar06
Contributor

@MisRob , thanks for assigning me, working on this and will update till tomorrow.

vtushar06

vtushar06 commented on Jun 16, 2025

@vtushar06
Contributor

Hi @MisRob,
I’ve opened a PR for this issue — just wanted to give you a quick heads-up. Looking forward to your feedback whenever you get a chance. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
[Remove Vuetify from Studio] Remove unused :v-deep styles from info modal · Issue #5095 · learningequality/studio