-
Notifications
You must be signed in to change notification settings - Fork 213
Fixes info modal icon click and keyboard navigation #5087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: hotfixes
Are you sure you want to change the base?
Conversation
@bjester I think that this is quite a high priority since users cannot open licenses info modal at all. Should I target |
Yeah I think you can target hotfixes. |
- fixes modal not appearing on help icon click - uses button to make icon part of keyboard navigation
Thanks @bjester, done |
Hey @misha – sorry for the delay! Thanks for proposing this fix and for confirming we’re already using the smallest (mini) size of KIconButton. Size: For dense form labels, we still need that smaller 16 px footprint. I’d be happy for us to explore adding a tiny/xs size in KDS—happy to open the ticket and draft the specs. Hover & Focus: I’ll create an inverted-fill icon state (solid circle + knockout “?”) to use for both hover and :focus-visible. This provides a clear affordance and also serves as a consistent keyboard-focus indicator to replace the current blue ring. I can share the SVGs and create demo wireframes if helpful. |
FYI we talked with @tomiwaoLE and there will be related KDS updates that will improve how icon buttons look like here. Details and priority to be determined soon. So we could address that at first, but if we're close to release at any point and this would be good to merge, I can also try some temporary overrides on Studio side. |
Summary
Fixes info modal not appearing on help icon click
Fixes help icon not being included in keyboard navigation
By using
KIconButton
instead ofKIcon
@jamalex @tomiwaoLE note visual differences. This is as close as possible that I can get with options available in
KIconButton
currently. Is it fine or do we need to plan some KDS updates?(note that I don't know if we should use the 'before' state as a reference of what it should actually look like - Studio icons underwent some refactors few months ago as part of migrating to KDS so it's all in flux)
Reviewer guidance
Notes
I will open issues for few visual problems I noticed:
mini
KIconButton
is ellipsis rather than circlular