-
Notifications
You must be signed in to change notification settings - Fork 231
[fix]:Remove Vuetify styles from InfoModal.vue and relocate license description styling #5129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix]:Remove Vuetify styles from InfoModal.vue and relocate license description styling #5129
Conversation
…ensing details
Hi @MisRob, I’ve fixed the linting issue and all checks are passing now. Could you please review and approve the PR? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vtushar06, thank you.
Gap between link and paragraph above seems to be larger now .
As per requirements, there should be no visual differences in before / after. I'm leaving few pointers. Before you request new review, please compare carefully everything one more time to the original version and make adjustments that are needed.
contentcuration/contentcuration/frontend/settings/pages/Storage/RequestForm.vue
Outdated
Show resolved
Hide resolved
Hi @MisRob I have resolved previous issue and set line height. to 1.5 as In testing, normal rendered with slightly tighter spacing, making the license description look more cramped than in production. |
Thanks @vtushar06. It looks fine overall, except still larger gap between link and paragraph I mentioned here. I've pushed a commit to resolve that and will merge now. |
Thanks a lot @MisRob for reviewing and making the final tweak! Really appreciate you catching that gap issue and pushing the fix. Glad it’s all set and merged now |
This PR removes unused Vuetify styles from InfoModal.vue and moves necessary styling (specifically the line-height for license descriptions) to RequestForm.vue, where it’s actually used.
Summary
These updates are part of the ongoing effort to remove Vuetify from the Studio codebase.
Changes made:
🧪 Manual Verification:
• Navigated to Settings > Storage > Request more space
• Opened the info modal beside “Who can use your content?”
• Manually toggled visibility of the modal in the component for testing
…
References
Fixes: #5095 – Remove unused :v-deep styles from info modal
• Original (closed) PR: #5112 – Closed to avoid git rebase issues
• Part of broader task: #5060 – Full removal of Vuetify from Studio
…
Reviewer guidance
To test:
1. Log in with: [email protected] / password: a
2. Go to Settings > Storage > Request more space
3. Open the info modal next to “Who can use your content?”
• If modal does not open, temporarily force visibility from the component code
4. Verify:
• Modal renders and styles apply correctly
• License description text is styled with correct line-height
• No visual difference compared to production
• All removed styles were unused and related to Vuetify
…