Skip to content

Work through each BOLT and fill out error conditions #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5 of 8 tasks
TheBlueMatt opened this issue Aug 25, 2018 · 7 comments · Fixed by #143
Closed
5 of 8 tasks

Work through each BOLT and fill out error conditions #129

TheBlueMatt opened this issue Aug 25, 2018 · 7 comments · Fixed by #143
Labels
request for review
Milestone
0.1

Comments

@TheBlueMatt
Copy link
Collaborator

TheBlueMatt commented Aug 25, 2018 •
edited
Loading

Need to make sure we're compliant with all the various actions we're supposed to take as specified in the BOLTs, as well as ensure ErrorActions are always Some() in HandleError. Some of these should be pretty easy, some will be way more involved.

  • BOLT 1
  • BOLT 2
  • BOLT 3
  • BOLT 4
  • BOLT 5
  • BOLT 7
  • BOLT 8
  • BOLT 9

BOLT 10 we don't have any implementation of yet (#58), and BOLT 11 is in rust-lightning-invoice.
@TheBlueMatt TheBlueMatt mentioned this issue Aug 25, 2018
Merged
@TheBlueMatt
Copy link
Collaborator Author

I think we're already good on BOLT 8 as there aren't really any "requirements" in it aside from the crypto spec, which we handle fine, and any errors result in disconnection, which I believe is correct.

This was referenced Aug 26, 2018
Merged
Merged
@TheBlueMatt TheBlueMatt added this to the 0.1 milestone Aug 30, 2018
@TheBlueMatt
Copy link
Collaborator Author

AFAICT, BOLT 3 stuff is all correct, again there aren't many requirements there just a list of scripts and tx formats, all of which should pretty immediately result in failing to send signatures to channel peers, but I read through it again as well and didnt see anything obvious.

@TheBlueMatt TheBlueMatt mentioned this issue Aug 31, 2018
Merged
@TheBlueMatt
Copy link
Collaborator Author

Lol, github got a bit overeager, sadly.

@TheBlueMatt TheBlueMatt reopened this Sep 3, 2018
This was referenced Sep 5, 2018
Closed
Merged
TheBlueMatt added a commit that referenced this issue Sep 5, 2018
@TheBlueMatt
Merge pull request #150 from TheBlueMatt/2018-09-bolt7-compliance
2a93f98 
Finish up #129 BOLT 7 compliance
@TheBlueMatt
Copy link
Collaborator Author

Yay BOLT 7!

@SWvheerden SWvheerden mentioned this issue Sep 19, 2018
Closed
@TheBlueMatt TheBlueMatt mentioned this issue Oct 1, 2018
Merged
@SWvheerden SWvheerden mentioned this issue Oct 15, 2018
Closed
@SWvheerden SWvheerden mentioned this issue Nov 1, 2018
Open
4 tasks
@TheBlueMatt
Copy link
Collaborator Author

Technically we know about all the various flags, even if we dont implement all the optional ones (see #236) so BOLT 9 is "implemented".

@SWvheerden SWvheerden mentioned this issue Nov 1, 2018
Closed
26 tasks
philipr-za added a commit to philipr-za/rust-lightning that referenced this issue Nov 23, 2018
@philipr-za
Merge branch 'master' into philip-lightningdevkit#129-bolt4-packet-fo…
79d0ada 
…rwarding-tests

# Conflicts:
#	src/ln/channelmanager.rs
@philipr-za philipr-za mentioned this issue Jan 15, 2019
Closed
@philipr-za philipr-za mentioned this issue Feb 1, 2019
Closed
@sdbondi sdbondi mentioned this issue Feb 21, 2019
Closed
@ariard
Copy link

ariard commented Jul 29, 2019

@rrybarczyk, this one should be a good first issue if you're looking for something to hack on, and nice to understand the whole procotol :)

(generally moar tests are always well welcomed)

@ConorOkus ConorOkus moved this to Todo in LDK Roadmap Dec 7, 2021
@ConorOkus ConorOkus moved this from Todo to In Progress in LDK Roadmap Dec 7, 2021
@TheBlueMatt
Copy link
Collaborator Author

ErrorAction has been required for quite some time.

@github-project-automation github-project-automation bot moved this from In Progress to Done in LDK Roadmap May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
request for review
Projects
LDK Roadmap
Status: Done
Milestone
0.1
Development

Successfully merging a pull request may close this issue.

Ensure handle_announcement_signatures always has a ErrorAction TheBlueMatt/rust-lightning
2 participants
@TheBlueMatt @ariard