-
Notifications
You must be signed in to change notification settings - Fork 406
Redo local channel tracking for route generation #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Seems to me best is to pass ChannelDetails (or a subset of it) as Event to Router when channels go to ChannelFunded, so Router will handle Event and add what needed to its maps. Maybe can be used to extend network map in the future from others sources than ChannelManager. I'm gonna work on that |
I feel a bit gross passing data back and forth between Router and ChannelManager as events, maybe just duplicate the channel_update message event handling calls to call both/ |
Call both ? Sorry doesn't seems clear to me, how Router is suppose to have access to ChannelManager local channels if it have any reference to it ? |
Sorry, as in add a handle_channel_update fn in ChannelMessageHandler and just have peer_handler call both the chan_handler.handle_channel_update and the route_handler.handle_channel_update. |
Add test_channel_update_local_channel Issue lightningdevkit#149
Add test_channel_update_local_channel Issue lightningdevkit#149
Effectively fixed in #841. |
Currently we require users to interrogate ChannelManager for info on non-public local channels, which makes it particularly hard to comply with BOLT 7 "SHOULD accept channel_updates for its own channels (even if non-public), in order to learn the associated origin nodes' forwarding parameters." I think the obvious solution is to track local channels in Router.
Tagging 0.1 so I can call BOLT 7 completed in #129 "with the exception of other 0.1-tagged issues"
The text was updated successfully, but these errors were encountered: