rfq+rfqmsg: relay errors received from price oracle #1751
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErrUnknownRejectWithCustomMsg constructs a RejectErr with error code 0 and the specified error message.
Simply forwards any error received from an oracle, following a price query, along with any reject message sent to the peer.
jtobin
added
error handling
RFQ
jtobin
force-pushed
the
relay-oracle-err
branch
from
a6cc909 to
8cee496
Compare
Pull Request Test Coverage Report for Build 17093326325Details
💛 - Coveralls |
|
@GeorgeTsagk pointed out out-of-band that this is probably a bad idea, since we may not actually want to share with a peer the reason we're not giving them a quote, and I'm inclined to agree. |
|
Yeah, I'm pretty sure this one is misguided. Going to close for the time being. |
This was referenced Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwards errors received from a price oracle back to the requesting peer in the 'Reject' message that it is sent. An error is simply rendered as a string and included in the 'msg' field of the RejectErr, which seems sufficient.
Resolves #1326.