Skip to content

rfq+rfqmsg: relay errors received from price oracle #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

rfq+rfqmsg: relay errors received from price oracle #1751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
482d3c5
rfqmsg: add reject-with-custom-message utility
jtobin Aug 20, 2025
2b2ead6
rfq: relay errors received from price oracle
jtobin Aug 20, 2025
8cee496
docs: add error-relaying release note
jtobin Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/release-notes/release-notes-0.7.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,10 @@
[PR](https://github.com/lightninglabs/taproot-assets/pull/1640) addresses the
issue.

- Errors received from a price oracle [are now relayed to a requesting
peer](https://github.com/lightninglabs/taproot-assets/pull/1751) in
the reject message sent to them, instead of being ignored.

## RPC Updates

## tapcli Updates
Expand Down Expand Up @@ -217,5 +221,6 @@

- ffranr
- George Tsagkarelis
- Jared Tobin
- Olaoluwa Osuntokun
- Oliver Gugger
4 changes: 2 additions & 2 deletions rfq/negotiator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@
// Send a reject message to the peer.
msg := rfqmsg.NewReject(
request.Peer, request.ID,
rfqmsg.ErrUnknownReject,
rfqmsg.ErrUnknownRejectWithCustomMsg(err.Error()),

Check failure on line 349 in rfq/negotiator.go

View workflow job for this annotation

GitHub Actions / Lint check 

The line is 82 characters long, which exceeds the maximum of 80 characters. (lll)
)
sendOutgoingMsg(msg)

Expand Down Expand Up @@ -441,7 +441,7 @@
// Send a reject message to the peer.
msg := rfqmsg.NewReject(
request.Peer, request.ID,
rfqmsg.ErrUnknownReject,
rfqmsg.ErrUnknownRejectWithCustomMsg(err.Error()),

Check failure on line 444 in rfq/negotiator.go

View workflow job for this annotation

GitHub Actions / Lint check 

The line is 82 characters long, which exceeds the maximum of 80 characters. (lll)
)
sendOutgoingMsg(msg)

Expand Down
9 changes: 9 additions & 0 deletions rfqmsg/reject.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,15 @@ var (
}
)

// ErrUnknownRejectWithCustomMsg produces the "unknown" error code, but
// pairs it with a custom error message
func ErrUnknownRejectWithCustomMsg(msg string) RejectErr {
return RejectErr{
Code: 0,
Msg: msg,
}
}

const (
// latestRejectVersion is the latest supported reject wire message data
// field version.
Expand Down
Loading