Fix button location for extra small screens #2164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guaris
approved these changes
Dec 5, 2018
nmelehan
commented
Dec 5, 2018
| @@ -4,3 +4,4 @@ pytest>=3.3.0 | |||
| tabulate>=0.8.2 | |||
| python-frontmatter>=0.4.2 | |||
| twisted==18.4.0 | |||
| attrs>=17.4.0 | |||
There was a problem hiding this comment.
Travis was showing an error like this when trying to import scrapy:
TypeError: attrib() got an unexpected keyword argument 'converter'`
Googling the error turned up:
python-jsonschema/jsonschema#449
Which said that older versions of the attrs library used an argument named convert instead of converter. That thread recommended having at least version 17.4.0 of attrs installed. Travis was showing that only 17.2.0 was installed (I think because one of the libraries we use listed that version as its dependency). Adding 17.4.0 as the minimum version in requirements.txt solved the issue in the next Travis builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2162 created an issue where the Try This Guide button is moved to the right out of the promo code banner box:
This PR fixes that by instead placing the button below the promo label and aligning it to the left (only for extra small screens):
Hercules PR:
https://github.com/linode/hercules/pull/112