Skip to content

Fix button location for extra small screens #2164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2018

Conversation

nmelehan
Copy link
Contributor

@nmelehan nmelehan commented Dec 5, 2018

#2162 created an issue where the Try This Guide button is moved to the right out of the promo code banner box:

screen shot 2018-12-05 at 4 31 19 pm

This PR fixes that by instead placing the button below the promo label and aligning it to the left (only for extra small screens):

screen shot 2018-12-05 at 4 32 04 pm

Hercules PR:
https://github.com/linode/hercules/pull/112

@@ -4,3 +4,4 @@ pytest>=3.3.0
tabulate>=0.8.2
python-frontmatter>=0.4.2
twisted==18.4.0
attrs>=17.4.0
Copy link
Contributor Author

@nmelehan nmelehan Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis was showing an error like this when trying to import scrapy:

TypeError: attrib() got an unexpected keyword argument 'converter'`

Googling the error turned up:
python-jsonschema/jsonschema#449

Which said that older versions of the attrs library used an argument named convert instead of converter. That thread recommended having at least version 17.4.0 of attrs installed. Travis was showing that only 17.2.0 was installed (I think because one of the libraries we use listed that version as its dependency). Adding 17.4.0 as the minimum version in requirements.txt solved the issue in the next Travis builds.

@nmelehan nmelehan merged commit 7378acf into linode:develop Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants