Skip to content

Fix button location for extra small screens #2164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2018
Merged

Fix button location for extra small screens #2164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07947bb
Fix button location for extra small screens
nmelehan Dec 5, 2018
976eb42
Attempted fix for docs404 Travis errors
nmelehan Dec 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ pytest>=3.3.0
tabulate>=0.8.2
python-frontmatter>=0.4.2
twisted==18.4.0
attrs>=17.4.0
Copy link
Contributor Author

@nmelehan nmelehan Dec 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis was showing an error like this when trying to import scrapy:

TypeError: attrib() got an unexpected keyword argument 'converter'`

Googling the error turned up:
python-jsonschema/jsonschema#449

Which said that older versions of the attrs library used an argument named convert instead of converter. That thread recommended having at least version 17.4.0 of attrs installed. Travis was showing that only 17.2.0 was installed (I think because one of the libraries we use listed that version as its dependency). Adding 17.4.0 as the minimum version in requirements.txt solved the issue in the next Travis builds.

2 changes: 1 addition & 1 deletion themes/docsmith/layouts/partials/includes_head_prod.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<link href="{{ relURL "build/stylesheets/home-42d5a39635.min.css" }}" rel='stylesheet' type='text/css'>
<link href="{{ relURL "build/stylesheets/home-84dcf75eeb.min.css" }}" rel='stylesheet' type='text/css'>
6 changes: 3 additions & 3 deletions themes/docsmith/layouts/partials/promo_code.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div markdown="0" class="signup-top">
<div class="row row-eq-height">
<div class="col-lg-9 col-md-9 col-xs-8">
<div class="row">
<div class="col-lg-9 col-md-9 col-sm-8 col-xs-12">
<span>
{{ if and ($.Params.promo_code) ($.Params.promo_code_amount) }}
Use promo code <strong>{{ $.Params.promo_code }}</strong> for ${{ $.Params.promo_code_amount }} credit on a new account.
Expand All @@ -9,7 +9,7 @@
{{ end }}
</span>
</div>
<div class="col-lg-3 col-md-3 col-xs-4 text-right">
<div class="col-lg-3 col-md-3 col-sm-4 col-xs-12">
<form action="https://manager.linode.com/session/signup">
<button type="submit" target="_blank" class="btn btn-blue btn-sm btn-border">Try this Guide</button>
</form>
Expand Down
4 changes: 2 additions & 2 deletions ...build/stylesheets/home-42d5a39635.min.css → ...build/stylesheets/home-84dcf75eeb.min.css
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 12 additions & 0 deletions themes/docsmith/static/build/stylesheets/home.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21328,6 +21328,18 @@ li.library-article-item:nth-child(odd) {
padding-top: 4px;
}
}
@media only screen and (max-width: 768px) {
.signup-top > div.row > div:last-child {
text-align: left;
margin-top: 8px;
}
}
@media only screen and (min-width: 768px) {
.signup-top > div.row > div:last-child {
text-align: right;
margin-top: 0;
}
}
.signup-top span {
font-family: Lato, sans-serif;
font-size: 18px;
Expand Down
4 changes: 2 additions & 2 deletions themes/docsmith/static/build/stylesheets/home.min.css
View file
Open in desktop

Large diffs are not rendered by default.