Skip to content

[DirectX] Implement Shader Flags Analysis for WaveOps #114565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #113505
bharadwajy opened this issue Nov 1, 2024 · 2 comments · Fixed by #118140
Closed
Tracked by #113505

[DirectX] Implement Shader Flags Analysis for WaveOps #114565

bharadwajy opened this issue Nov 1, 2024 · 2 comments · Fixed by #118140
Assignees
@inbelic
Labels
backend:DirectX

Comments

@bharadwajy
Copy link
Contributor

bharadwajy commented Nov 1, 2024 •
edited
Loading

Set function-level flag WaveOps flag if the function uses DXIL Wave Operations - see here

This flag is named m_bWaveOps in dxc sources.

AC:

Add tests to verify the flag is set.
@bharadwajy bharadwajy mentioned this issue Nov 1, 2024
Closed
5 tasks
@bharadwajy bharadwajy moved this to Planning in HLSL Support Nov 5, 2024
@davidcook-msft davidcook-msft moved this from Planning to Ready in HLSL Support Nov 5, 2024
@inbelic inbelic self-assigned this Nov 18, 2024
@inbelic
Copy link
Contributor

inbelic commented Nov 18, 2024

I will take a look at this as a use-case of #115912

@damyanp
Copy link
Contributor

damyanp commented Nov 21, 2024

Waiting on #111867

@inbelic inbelic mentioned this issue Nov 22, 2024
Merged
@inbelic inbelic moved this from Ready to Active in HLSL Support Nov 25, 2024
@inbelic inbelic mentioned this issue Nov 29, 2024
Merged
@inbelic inbelic moved this from Active to Needs Review in HLSL Support Nov 29, 2024
@inbelic inbelic moved this from Needs Review to Ready in HLSL Support Dec 16, 2024
@damyanp damyanp moved this from Ready to Active in HLSL Support Jan 6, 2025
@damyanp damyanp moved this from Active to Needs Review in HLSL Support Jan 23, 2025
@github-project-automation github-project-automation bot moved this from Needs Review to Closed in HLSL Support Feb 14, 2025
joaosaffran pushed a commit to joaosaffran/llvm-project that referenced this issue Feb 14, 2025
@inbelic
[DirectX][ShaderFlags] Add analysis for WaveOps flag (llvm#118140)
97b7ec6 
- Check each call instruction for a `WaveOp` intrinsic and set the
`WaveOps` flag if this is true for any intrinsic, Done in
DXILShaderFlags.cpp

Resolves llvm#114565
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this issue Feb 24, 2025
@inbelic @sivan-shani
[DirectX][ShaderFlags] Add analysis for WaveOps flag (llvm#118140)
38af159 
- Check each call instruction for a `WaveOp` intrinsic and set the
`WaveOps` flag if this is true for any intrinsic, Done in
DXILShaderFlags.cpp

Resolves llvm#114565
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inbelic inbelic

Labels
backend:DirectX
Projects
HLSL Support
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DirectX][ShaderFlags] Add analysis for WaveOps flag inbelic/llvm-project
4 participants
@damyanp @EugeneZelenko @bharadwajy @inbelic