[BOLT] Drop blocks without profile in BAT YAML

[aaupov]

Align BAT YAML (DataAggregator) to YAMLProfileWriter which drops blocks
without profile:

llvm-project/bolt/lib/Profile/YAMLProfileWriter.cpp

Lines 162 to 176 in 61372fc

	// Skip printing if there's no profile data for non-entry basic block.
	// Include landing pads with non-zero execution count.
	if (YamlBB.CallSites.empty() && !BB->isEntryPoint() &&
	!(BB->isLandingPad() && BB->getKnownExecutionCount() != 0)) {
	// Include blocks having successors or predecessors with positive counts.
	uint64_t SuccessorExecCount = 0;
	for (const BinaryBasicBlock::BinaryBranchInfo &BranchInfo :
	BB->branch_info())
	SuccessorExecCount += BranchInfo.Count;
	uint64_t PredecessorExecCount = 0;
	for (auto Pred : BB->predecessors())
	PredecessorExecCount += Pred->getBranchInfo(*BB).Count;
	if (!SuccessorExecCount && !PredecessorExecCount)
	continue;
	}

Test Plan: NFCI

[llvmbot]

@llvm/pr-subscribers-bolt

Author: Amir Ayupov (aaupov)

Changes

Align BAT YAML (DataAggregator) to YAMLProfileWriter which drops blocks
without profile:
https://github.com/llvm/llvm-project/blob/main/bolt/lib/Profile/YAMLProfileWriter.cpp#L162-L176

Test Plan: NFCI

---

Full diff: https://github.com/llvm/llvm-project/pull/107970.diff

1 Files Affected:

• (modified) bolt/lib/Profile/DataAggregator.cpp (+9-5)

diff --git a/bolt/lib/Profile/DataAggregator.cpp b/bolt/lib/Profile/DataAggregator.cpp
index 10d745cc69824b..4aeeb1daab1b94 100644
--- a/bolt/lib/Profile/DataAggregator.cpp
+++ b/bolt/lib/Profile/DataAggregator.cpp
@@ -2427,11 +2427,15 @@ std::error_code DataAggregator::writeBATYAML(BinaryContext &BC,
           }
         }
       }
-      // Drop blocks without a hash, won't be useful for stale matching.
-      llvm::erase_if(YamlBF.Blocks,
-                     [](const yaml::bolt::BinaryBasicBlockProfile &YamlBB) {
-                       return YamlBB.Hash == (yaml::Hex64)0;
-                     });
+      // Skip printing if there's no profile data
+      llvm::erase_if(
+          YamlBF.Blocks, [](const yaml::bolt::BinaryBasicBlockProfile &YamlBB) {
+            auto HasCount = [](const auto &SI) { return SI.Count; };
+            bool HasAnyCount = YamlBB.ExecCount ||
+                               llvm::any_of(YamlBB.Successors, HasCount) ||
+                               llvm::any_of(YamlBB.CallSites, HasCount);
+            return !HasAnyCount;
+          });
       BP.Functions.emplace_back(YamlBF);
     }
   }

[rafaelauler]

LG