Skip to content

[BOLT] Drop blocks without profile in BAT YAML #107970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 11, 2024
Merged

[BOLT] Drop blocks without profile in BAT YAML #107970

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b867a6
[𝘀𝗽𝗿] changes to main this commit is based on
aaupov Sep 10, 2024
f0f8a10
[𝘀𝗽𝗿] initial version
aaupov Sep 10, 2024
a1a651f
[𝘀𝗽𝗿] changes introduced through rebase
aaupov Sep 11, 2024
579f7a8
rebase
aaupov Sep 11, 2024
33c5a0c
[𝘀𝗽𝗿] changes introduced through rebase
aaupov Sep 11, 2024
fe173d0
rebase
aaupov Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions bolt/lib/Profile/DataAggregator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2427,11 +2427,15 @@ std::error_code DataAggregator::writeBATYAML(BinaryContext &BC,
}
}
}
// Drop blocks without a hash, won't be useful for stale matching.
llvm::erase_if(YamlBF.Blocks,
[](const yaml::bolt::BinaryBasicBlockProfile &YamlBB) {
return YamlBB.Hash == (yaml::Hex64)0;
});
// Skip printing if there's no profile data
llvm::erase_if(
YamlBF.Blocks, [](const yaml::bolt::BinaryBasicBlockProfile &YamlBB) {
auto HasCount = [](const auto &SI) { return SI.Count; };
bool HasAnyCount = YamlBB.ExecCount ||
llvm::any_of(YamlBB.Successors, HasCount) ||
llvm::any_of(YamlBB.CallSites, HasCount);
return !HasAnyCount;
});
BP.Functions.emplace_back(YamlBF);
}
}
Expand Down
Loading