[llvm] Enable building Analysis plugins on windows #112303
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable building InlineAdvisorPlugin and InlineOrderPlugin on windows for shared library builds. This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and LLVM plugins on window.
llvmbot
added
the
llvm:analysis
Open
40 tasks
|
@llvm/pr-subscribers-llvm-analysis Author: Thomas Fransham (fsfod) ChangesEnable building InlineAdvisorPlugin and InlineOrderPlugin on windows for shared library builds. This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and LLVM plugins on window. Full diff: https://github.com/llvm/llvm-project/pull/112303.diff 2 Files Affected:
diff --git a/llvm/unittests/Analysis/InlineAdvisorPlugin/CMakeLists.txt b/llvm/unittests/Analysis/InlineAdvisorPlugin/CMakeLists.txt
index 22cd0cb1d9a034..deabf110f2e439 100644
--- a/llvm/unittests/Analysis/InlineAdvisorPlugin/CMakeLists.txt
+++ b/llvm/unittests/Analysis/InlineAdvisorPlugin/CMakeLists.txt
@@ -2,7 +2,7 @@
# libraries, but expects them to exist in the process loading the plugin. This
# doesn't work with DLLs on Windows (where a shared library can't have undefined
# references), so just skip this testcase on Windows.
-if (NOT WIN32 AND NOT CYGWIN)
+if ((NOT WIN32 OR LLVM_BUILD_LLVM_DYLIB) AND NOT CYGWIN)
unset(LLVM_LINK_COMPONENTS)
add_llvm_library(InlineAdvisorPlugin MODULE BUILDTREE_ONLY
InlineAdvisorPlugin.cpp
diff --git a/llvm/unittests/Analysis/InlineOrderPlugin/CMakeLists.txt b/llvm/unittests/Analysis/InlineOrderPlugin/CMakeLists.txt
index cc470a934426d5..0b37cebe3da6de 100644
--- a/llvm/unittests/Analysis/InlineOrderPlugin/CMakeLists.txt
+++ b/llvm/unittests/Analysis/InlineOrderPlugin/CMakeLists.txt
@@ -2,7 +2,7 @@
# libraries, but expects them to exist in the process loading the plugin. This
# doesn't work with DLLs on Windows (where a shared library can't have undefined
# references), so just skip this testcase on Windows.
-if (NOT WIN32 AND NOT CYGWIN)
+if ((NOT WIN32 OR LLVM_BUILD_LLVM_DYLIB) AND NOT CYGWIN)
unset(LLVM_LINK_COMPONENTS)
add_llvm_library(InlineOrderPlugin MODULE BUILDTREE_ONLY
InlineOrderPlugin.cpp
|
|
Hi @dwblaikie, this lgtm but since I could not find an obvious reviewer maybe that's around an area you have experience with? |
dwblaikie
approved these changes
Oct 25, 2024
Thank you! |
winner245
pushed a commit
to winner245/llvm-project
that referenced
this pull request
Oct 26, 2024
Enable building InlineAdvisorPlugin and InlineOrderPlugin on windows for shared library builds. This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and LLVM plugins on window.
NoumanAmir657
pushed a commit
to NoumanAmir657/llvm-project
that referenced
this pull request
Nov 4, 2024
Enable building InlineAdvisorPlugin and InlineOrderPlugin on windows for shared library builds. This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and LLVM plugins on window.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Jul 30, 2025
In llvm#112303 they were enabled for Windows dylib builds, but the condition excluded Cygwin in that case. Their dynamic libraries work the same way, so adjust the condition accordingly. This fixes the plugin tests on Cygwin.
jeremyd2019
added a commit
that referenced
this pull request
Jul 31, 2025
In #112303 they were enabled for Windows dylib builds, but the condition excluded Cygwin in that case. Their dynamic libraries work the same way, so adjust the condition accordingly. This fixes the plugin tests on Cygwin.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Aug 6, 2025
In llvm#112303 they were enabled for Windows dylib builds, but the condition excluded Cygwin in that case. Their dynamic libraries work the same way, so adjust the condition accordingly. This fixes the plugin tests on Cygwin.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Aug 9, 2025
In llvm#112303 they were enabled for Windows dylib builds, but the condition excluded Cygwin in that case. Their dynamic libraries work the same way, so adjust the condition accordingly. This fixes the plugin tests on Cygwin.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Aug 12, 2025
In llvm#112303 they were enabled for Windows dylib builds, but the condition excluded Cygwin in that case. Their dynamic libraries work the same way, so adjust the condition accordingly. This fixes the plugin tests on Cygwin.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Aug 26, 2025
In llvm#112303 they were enabled for Windows dylib builds, but the condition excluded Cygwin in that case. Their dynamic libraries work the same way, so adjust the condition accordingly. This fixes the plugin tests on Cygwin.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Sep 12, 2025
In llvm#112303 they were enabled for Windows dylib builds, but the condition excluded Cygwin in that case. Their dynamic libraries work the same way, so adjust the condition accordingly. This fixes the plugin tests on Cygwin.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Sep 23, 2025
In llvm#112303 they were enabled for Windows dylib builds, but the condition excluded Cygwin in that case. Their dynamic libraries work the same way, so adjust the condition accordingly. This fixes the plugin tests on Cygwin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable building InlineAdvisorPlugin and InlineOrderPlugin on windows for shared library builds.
This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and LLVM plugins on window.