[llvm] Enable building Analysis plugins on Cygwin #151397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In llvm#112303 they were enabled for Windows dylib builds, but the condition excluded Cygwin in that case. Their dynamic libraries work the same way, so adjust the condition accordingly. This fixes the plugin tests on Cygwin.
llvmbot
added
the
llvm:analysis
|
@llvm/pr-subscribers-llvm-analysis Author: None (jeremyd2019) ChangesIn #112303 they were enabled for Windows dylib builds, but the condition excluded Cygwin in that case. Their dynamic libraries work the same way, so adjust the condition accordingly. This fixes the plugin tests on Cygwin. Full diff: https://github.com/llvm/llvm-project/pull/151397.diff 2 Files Affected:
diff --git a/llvm/unittests/Analysis/InlineAdvisorPlugin/CMakeLists.txt b/llvm/unittests/Analysis/InlineAdvisorPlugin/CMakeLists.txt
index deabf110f2e43..d9da627ad52e3 100644
--- a/llvm/unittests/Analysis/InlineAdvisorPlugin/CMakeLists.txt
+++ b/llvm/unittests/Analysis/InlineAdvisorPlugin/CMakeLists.txt
@@ -2,7 +2,7 @@
# libraries, but expects them to exist in the process loading the plugin. This
# doesn't work with DLLs on Windows (where a shared library can't have undefined
# references), so just skip this testcase on Windows.
-if ((NOT WIN32 OR LLVM_BUILD_LLVM_DYLIB) AND NOT CYGWIN)
+if ((NOT WIN32 AND NOT CYGWIN) OR LLVM_BUILD_LLVM_DYLIB)
unset(LLVM_LINK_COMPONENTS)
add_llvm_library(InlineAdvisorPlugin MODULE BUILDTREE_ONLY
InlineAdvisorPlugin.cpp
diff --git a/llvm/unittests/Analysis/InlineOrderPlugin/CMakeLists.txt b/llvm/unittests/Analysis/InlineOrderPlugin/CMakeLists.txt
index 0b37cebe3da6d..941e18efc1a52 100644
--- a/llvm/unittests/Analysis/InlineOrderPlugin/CMakeLists.txt
+++ b/llvm/unittests/Analysis/InlineOrderPlugin/CMakeLists.txt
@@ -2,7 +2,7 @@
# libraries, but expects them to exist in the process loading the plugin. This
# doesn't work with DLLs on Windows (where a shared library can't have undefined
# references), so just skip this testcase on Windows.
-if ((NOT WIN32 OR LLVM_BUILD_LLVM_DYLIB) AND NOT CYGWIN)
+if ((NOT WIN32 AND NOT CYGWIN) OR LLVM_BUILD_LLVM_DYLIB)
unset(LLVM_LINK_COMPONENTS)
add_llvm_library(InlineOrderPlugin MODULE BUILDTREE_ONLY
InlineOrderPlugin.cpp
|
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Aug 6, 2025
In llvm#112303 they were enabled for Windows dylib builds, but the condition excluded Cygwin in that case. Their dynamic libraries work the same way, so adjust the condition accordingly. This fixes the plugin tests on Cygwin.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Aug 9, 2025
In llvm#112303 they were enabled for Windows dylib builds, but the condition excluded Cygwin in that case. Their dynamic libraries work the same way, so adjust the condition accordingly. This fixes the plugin tests on Cygwin.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Aug 12, 2025
In llvm#112303 they were enabled for Windows dylib builds, but the condition excluded Cygwin in that case. Their dynamic libraries work the same way, so adjust the condition accordingly. This fixes the plugin tests on Cygwin.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Aug 26, 2025
In llvm#112303 they were enabled for Windows dylib builds, but the condition excluded Cygwin in that case. Their dynamic libraries work the same way, so adjust the condition accordingly. This fixes the plugin tests on Cygwin.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Sep 12, 2025
In llvm#112303 they were enabled for Windows dylib builds, but the condition excluded Cygwin in that case. Their dynamic libraries work the same way, so adjust the condition accordingly. This fixes the plugin tests on Cygwin.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Sep 23, 2025
In llvm#112303 they were enabled for Windows dylib builds, but the condition excluded Cygwin in that case. Their dynamic libraries work the same way, so adjust the condition accordingly. This fixes the plugin tests on Cygwin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #112303 they were enabled for Windows dylib builds, but the condition excluded Cygwin in that case. Their dynamic libraries work the same way, so adjust the condition accordingly.
This fixes the plugin tests on Cygwin.