Github Automation: Add support for an optional colon after command name #66540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
execute_command function (example -> /cherry-pick:)
tstellar
approved these changes
Sep 16, 2023
I tested it with a lot of sample strings and it worked so I think it's correct. |
jroelofs
reviewed
Sep 22, 2023
| """ | ||
| for line in sys.stdin: | ||
| line.rstrip() | ||
| m = re.search(r"/([a-z-]+)\s(.+)", line) | ||
| m = re.search(r"/([a-z-]+)(?::)?\s(.+)", line) |
There was a problem hiding this comment.
How about:
Suggested change
| m = re.search(r"/([a-z-]+)(?::)?\s(.+)", line) | |
| m = re.search(r"/([a-z-]+):?\s(.+)", line) |
Then the reader doesn't have to remember the rules for (?:...)s
|
I think after #66781 this will no longer work. |
|
@llvm/pr-subscribers-github-workflow ChangesAs requested in #64803 example -> /cherry-pick: or /branch: Full diff: https://github.com/llvm/llvm-project/pull/66540.diff 1 Files Affected:
diff --git a/llvm/utils/git/github-automation.py b/llvm/utils/git/github-automation.py
index eac5816b5499f6a..090359b8822a73a 100755
--- a/llvm/utils/git/github-automation.py
+++ b/llvm/utils/git/github-automation.py
@@ -572,12 +572,12 @@ def execute_command(self) -> bool:
"""
This function reads lines from STDIN and executes the first command
that it finds. The 2 supported commands are:
- /cherry-pick commit0 <commit1> <commit2> <...>
- /branch <owner>/<repo>/<branch>
+ /cherry-pick<:> commit0 <commit1> <commit2> <...>
+ /branch<:> <owner>/<repo>/<branch>
"""
for line in sys.stdin:
line.rstrip()
- m = re.search(r"/([a-z-]+)\s(.+)", line)
+ m = re.search(r"/([a-z-]+)(?::)?\s(.+)", line)
if not m:
continue
command = m.group(1)
|
Error: Command failed due to missing milestone. |
1 similar comment
Error: Command failed due to missing milestone. |
|
Yes? The colon would still work if it's followed by a space. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #64803
example -> /cherry-pick: or /branch: