[github] Make branch workflow more robust #66781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid false positives by requiring space after `/branch` command so the action won't trigger on diffs that include filenames like `.../BranchProbabilityInfo.cpp`.
|
@llvm/pr-subscribers-github-workflow ChangesAvoid false positives by requiring space after Full diff: https://github.com/llvm/llvm-project/pull/66781.diff 1 Files Affected:
diff --git a/.github/workflows/issue-release-workflow.yml b/.github/workflows/issue-release-workflow.yml
index bd6d09cc65e0857..b09ef6555fa9017 100644
--- a/.github/workflows/issue-release-workflow.yml
+++ b/.github/workflows/issue-release-workflow.yml
@@ -70,7 +70,7 @@ jobs:
if: >-
(github.repository == 'llvm/llvm-project') &&
!startswith(github.event.comment.body, '<!--IGNORE-->') &&
- contains(github.event.comment.body, '/branch')
+ contains(github.event.comment.body, '/branch ')
steps:
- name: Fetch LLVM sources
|
Error: Command failed due to missing milestone. |
VoltrexKeyva
approved these changes
Sep 19, 2023
This was referenced Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid false positives by requiring space after
/branchcommand so the action won't trigger on diffs that include filenames like.../BranchProbabilityInfo.cpp.