[runtimes] Add missing test dependencies to check-all #75090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-apply 7f215b1, which was reverted in a9e3d23. The orginal commit uncovered a bug that was fixed by 4701f77. Fixes llvm#58680
|
@zmodem I've tested this with the config you provided in #72955 (comment) Is there some way to test this with the chromium config before we commit it? |
petrhosek
approved these changes
Dec 11, 2023
Thanks for checking!
I just tried it in our Linux environment and it works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-apply 7f215b1, which was reverted in a9e3d23.
The orginal commit uncovered a bug that was fixed by 4701f77.
Fixes #58680