-
Notifications
You must be signed in to change notification settings - Fork 13.4k
[MIPS] match llvm.{min,max}num with {min,max}.fmt for R6 #89021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We need a real regression test for fmax/fmin. Please add a new one. |
abe5343
to
b50b5af
Compare
That test's for For the test in this PR, we definitely need a new one. |
b50b5af
to
5e31f72
Compare
- The behavior is similar to UCOMISD on x86, which is also used to compare two fp values, specifically on handling of NaNs. - Update related tests regarding this change. - Add a new test. Note that this test do not cover pre-r6 targets since they are expanded into a libcall.
5e31f72
to
189bed5
Compare
@Cyanoxygen MSA has fmax.fmt/fmin.fmt, too. |
Yes, I would like to try to look into that. |
Ohh, this patch is not correct. In https://llvm.org/docs/LangRef.html#llvm-minnum-intrinsic :
|
)" This reverts commit 7152194.
llvm.minimum
andllvm.maximum
intrinsics for MIPS R6 and Pre-R6.Part of #64207