Add -DLLVM_DISABLE_ASSEMBLY_FILES=ON to work around a bug in Apple Clang #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkistanova
approved these changes
Mar 5, 2024
dyung
added a commit
that referenced
this pull request
Mar 10, 2024
…Apple Clang (#129)" (#132) Updating to Apple Clang 1500.3.9.4 fixes the problem that was causing test failures. Build/test is now passing: https://lab.llvm.org/staging/#/builders/188/builds/444.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two build-id related LLD tests are failing on the MacOS builder I am trying to bring up apparently due to a bug in the version of Apple clang installed on the machine. (See llvm/llvm-project#83940 and llvm/llvm-project#81967).
The suggested workaround of adding
-DLLVM_DISABLE_ASSEMBLY_FILES=ONseems to work on the bot, so add that to the configuration.