Skip to content

Revert "Add -DLLVM_DISABLE_ASSEMBLY_FILES=ON to work around a bug in Apple Clang (#129)" #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

dyung
Copy link
Contributor

@dyung dyung commented Mar 8, 2024

Updating to Apple Clang 1500.3.9.4 fixes the problem that was causing test failures.

Build/test is now passing: https://lab.llvm.org/staging/#/builders/188/builds/444.

…Apple Clang (llvm#129)"

This reverts commit d91b8b9.

Updating to Apple Clang 1500.3.9.4 fixes the problem that was causing test failures.
@dyung dyung requested a review from gkistanova March 8, 2024 08:09
Copy link
Contributor

@gkistanova gkistanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dyung dyung merged commit 332f010 into llvm:main Mar 10, 2024
@dyung dyung deleted the dyung/main/129-revert branch March 10, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants