Split API into cross-platform OS-detection and native-only Platform i… #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nquiry. The cross-platform OS detection is in `package:platform/host.dart`, in the `HostPlatform` class. The native-only platform inspection in `package:platform/native.dart` in the `NativePlatform` class. There are also `package:platform/host_test.dart`, and `package:platform/native_test.dart`, which provides a mock for each of the platform classes, `MockHostPlatform` and `MockNativePlatform`. Existing code can keep importing `package:platform/platform.dart`, which exports the `host.dart` library, but also type aliases for native-capable platforms to match the existing. `Platform`, `FakePlatform` and `LocalPlatform` names. Those legacy names will eventually be deprecated.
Create migration-guide.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cross-platform OS detection is in
package:platform/host.dart, in theHostPlatformclass.The native-only platform inspection in
package:platform/native.dartin theNativePlatformclass.There are also
package:platform/host_test.dart, andpackage:platform/native_test.dart, which provides a mock for each of the platform classes,MockHostPlatformandMockNativePlatform.Existing code can keep importing
package:platform/platform.dart, which exports thehost.dartlibrary, but also type-aliases for native-capable platforms to match the existingPlatform,FakePlatformandLocalPlatformnames. Those legacy names will eventually be deprecated.