🔃 [EngCom] Public Pull Requests - 2.2-develop

magento-engcom-team · web-flow · commit 695aaf80220c · 2018-06-13T12:55:05.000-05:00
Accepted Public Pull Requests: - #16048: fix: prevent inline-block issue in name form due to space and font-size (by @DanielRuf) - #16002: bugfix checkout page cart icon color (by @Karlasa) - #16023: [Backport 2.2] Wishlist: Remove unnecessary parameter from invoking toHtml() method (by @rogyar) - #16001: Extend default config instead overwrite (by @likemusic) - #15991: fix for dropdown toggle icon in cart (by @Karlasa) - #15907: fixed word typo (by @ledian-hymetllari) - #15936: #15308 removed extraneous margin (by @StevenGuapaBV) - #15914: [Resolved : Changing @tab-content__border variable has no effect in B� (by @hitesh-wagento) - #15878: [Resolved : limiter float too generic] (by @hitesh-wagento) Fixed GitHub Issues: - #16047: inline-block issue in name form (reported by @DanielRuf) has been fixed in #16048 by @DanielRuf in 2.2-develop branch Related commits: 1. 587584c - #15308: extraneous margins on product list and product list items (reported by @DanielRuf) has been fixed in #15936 by @StevenGuapaBV in 2.2-develop branch Related commits: 1. cae12b1 - #14999: Changing @tab-content__border variable has no effect in Blank theme (reported by @denistrator) has been fixed in #15914 by @hitesh-wagento in 2.2-develop branch Related commits: 1. 4877e4c - #15323: limiter float too generic (reported by @DanielRuf) has been fixed in #15878 by @hitesh-wagento in 2.2-develop branch Related commits: 1. 1b9043b
diff --git a/app/code/Magento/Customer/view/frontend/templates/widget/name.phtml b/app/code/Magento/Customer/view/frontend/templates/widget/name.phtml
@@ -28,20 +28,15 @@ $suffix = $block->showSuffix();
 ?>
 <?php if (($prefix || $middle || $suffix) && !$block->getNoWrap()): ?>
 <div class="field required fullname <?= $block->escapeHtmlAttr($block->getContainerClassName()) ?>">
-    <label for="<?= $block->escapeHtmlAttr($block->getFieldId('firstname')) ?>" class="label">
-        <span><?= $block->escapeHtml(__('Name')) ?></span>
-    </label>
+    <label for="<?= $block->escapeHtmlAttr($block->getFieldId('firstname')) ?>" class="label"><span><?= $block->escapeHtml(__('Name')) ?></span></label>
     <div class="control">
         <fieldset class="fieldset fieldset-fullname">
         <div class="fields">
 <?php endif; ?>
 
     <?php if ($prefix): ?>
         <div class="field field-name-prefix<?php if ($block->isPrefixRequired()) echo ' required' ?>">
-            <label class="label" for="<?= $block->escapeHtmlAttr($block->getFieldId('prefix')) ?>">
-                <span><?= $block->escapeHtml($block->getStoreLabel('prefix')) ?></span>
-            </label>
-
+            <label class="label" for="<?= $block->escapeHtmlAttr($block->getFieldId('prefix')) ?>"><span><?= $block->escapeHtml($block->getStoreLabel('prefix')) ?></span></label>
             <div class="control">
                 <?php if ($block->getPrefixOptions() === false): ?>
                     <input type="text" id="<?= $block->escapeHtmlAttr($block->getFieldId('prefix')) ?>"
@@ -65,10 +60,7 @@ $suffix = $block->showSuffix();
         </div>
     <?php endif; ?>
         <div class="field field-name-firstname required">
-            <label class="label" for="<?= $block->escapeHtmlAttr($block->getFieldId('firstname')) ?>">
-                <span><?= $block->escapeHtml($block->getStoreLabel('firstname')) ?></span>
-            </label>
-
+            <label class="label" for="<?= $block->escapeHtmlAttr($block->getFieldId('firstname')) ?>"><span><?= $block->escapeHtml($block->getStoreLabel('firstname')) ?></span></label>
             <div class="control">
                 <input type="text" id="<?= $block->escapeHtmlAttr($block->getFieldId('firstname')) ?>"
                        name="<?= $block->escapeHtmlAttr($block->getFieldName('firstname')) ?>"
@@ -80,10 +72,7 @@ $suffix = $block->showSuffix();
     <?php if ($middle): ?>
         <?php $isMiddlenameRequired = $block->isMiddlenameRequired(); ?>
         <div class="field field-name-middlename<?= $isMiddlenameRequired ? ' required' : '' ?>">
-            <label class="label" for="<?= $block->escapeHtmlAttr($block->getFieldId('middlename')) ?>">
-                <span><?= $block->escapeHtml($block->getStoreLabel('middlename')) ?></span>
-            </label>
-
+            <label class="label" for="<?= $block->escapeHtmlAttr($block->getFieldId('middlename')) ?>"><span><?= $block->escapeHtml($block->getStoreLabel('middlename')) ?></span></label>
             <div class="control">
                 <input type="text" id="<?= $block->escapeHtmlAttr($block->getFieldId('middlename')) ?>"
                        name="<?= $block->escapeHtmlAttr($block->getFieldName('middlename')) ?>"
@@ -94,10 +83,7 @@ $suffix = $block->showSuffix();
         </div>
     <?php endif; ?>
         <div class="field field-name-lastname required">
-            <label class="label" for="<?= $block->escapeHtmlAttr($block->getFieldId('lastname')) ?>">
-                <span><?= $block->escapeHtml($block->getStoreLabel('lastname')) ?></span>
-            </label>
-
+            <label class="label" for="<?= $block->escapeHtmlAttr($block->getFieldId('lastname')) ?>"><span><?= $block->escapeHtml($block->getStoreLabel('lastname')) ?></span></label>
             <div class="control">
                 <input type="text" id="<?= $block->escapeHtmlAttr($block->getFieldId('lastname')) ?>"
                        name="<?= $block->escapeHtmlAttr($block->getFieldName('lastname')) ?>"
@@ -108,10 +94,7 @@ $suffix = $block->showSuffix();
         </div>
     <?php if ($suffix): ?>
         <div class="field field-name-suffix<?php if ($block->isSuffixRequired()) echo ' required' ?>">
-            <label class="label" for="<?= $block->escapeHtmlAttr($block->getFieldId('suffix')) ?>">
-                <span><?= $block->escapeHtml($block->getStoreLabel('suffix')) ?></span>
-            </label>
-
+            <label class="label" for="<?= $block->escapeHtmlAttr($block->getFieldId('suffix')) ?>"><span><?= $block->escapeHtml($block->getStoreLabel('suffix')) ?></span></label>
             <div class="control">
                 <?php if ($block->getSuffixOptions() === false): ?>
                     <input type="text" id="<?= $block->escapeHtmlAttr($block->getFieldId('suffix')) ?>"
diff --git a/app/code/Magento/Wishlist/view/frontend/templates/item/list.phtml b/app/code/Magento/Wishlist/view/frontend/templates/item/list.phtml
@@ -20,7 +20,7 @@ $columns = $block->getColumns();
         <?= /* @noEscape */ ($iterator++ == 1) ? '<li data-row="product-item" class="product-item" id="item_' . $block->escapeHtmlAttr($item->getId()) . '">' : '</li><li class="product-item" id="item_' . $block->escapeHtmlAttr($item->getId()) . '">' ?>
             <div class="product-item-info" data-container="product-grid">
                 <?php foreach ($columns as $column): ?>
-                    <?php $column->setItem($item); echo $column->toHtml($item);?>
+                    <?= $column->setItem($item)->toHtml() ?>
                 <?php endforeach; ?>
             </div>
         <?= ($iterator == count($block->getItems())+1) ? '</li>' : '' ?>
diff --git a/app/design/frontend/Magento/blank/Magento_Catalog/web/css/source/module/_toolbar.less b/app/design/frontend/Magento/blank/Magento_Catalog/web/css/source/module/_toolbar.less
@@ -188,11 +188,10 @@
         .lib-icon-font-symbol(@icon-list);
     }
 
-    .limiter {
-        float: right;
-
-        .products.wrapper ~ .toolbar & {
+    .toolbar {
+        .products.wrapper ~ & .limiter {
             display: block;
+            float: right;
         }
     }
 }
diff --git a/app/design/frontend/Magento/blank/Magento_Checkout/web/css/source/module/checkout/_estimated-total.less b/app/design/frontend/Magento/blank/Magento_Checkout/web/css/source/module/checkout/_estimated-total.less
@@ -35,7 +35,11 @@
             .action {
                 &.showcart {
                     &:before {
-                        .lib-css(color, @primary__color);
+                        .lib-css(color, @button__color);
+                    }
+                    
+                    &:hover:before {
+                        .lib-css(color, @button__hover__color);
                     }
                 }
             }
diff --git a/app/design/frontend/Magento/blank/web/css/source/_extends.less b/app/design/frontend/Magento/blank/web/css/source/_extends.less
@@ -1402,7 +1402,7 @@
         &.active {
             > .title {
                 .lib-icon-font-symbol(
-                @_icon-font-content: @icon-prev,
+                @_icon-font-content: @icon-up,
                 @_icon-font-position: after
                 );
             }
diff --git a/app/design/frontend/Magento/blank/web/css/source/_sections.less b/app/design/frontend/Magento/blank/web/css/source/_sections.less
@@ -20,9 +20,7 @@
 
 .media-width(@extremum, @break) when (@extremum = 'min') and (@break = @screen__m) {
     .product.data.items {
-        .lib-data-tabs(
-            @_tab-content-border-top-status: true
-        );
+        .lib-data-tabs();
     }
 }
 
diff --git a/app/design/frontend/Magento/blank/web/css/source/_variables.less b/app/design/frontend/Magento/blank/web/css/source/_variables.less
@@ -15,6 +15,16 @@
 @font-family-name__base: 'Open Sans';
 @font-family__base: @font-family-name__base, @font-family__sans-serif;
 
+//
+//  Sections variables
+//  _____________________________________________
+
+//
+//  Tabs
+//  ---------------------------------------------
+@tab-content__border-top-status: true;
+
+
 //
 //  Sidebar
 //  ---------------------------------------------
diff --git a/app/design/frontend/Magento/luma/Magento_Catalog/web/css/source/module/_listings.less b/app/design/frontend/Magento/luma/Magento_Catalog/web/css/source/module/_listings.less
@@ -167,11 +167,11 @@
     .column.main {
         .product {
             &-items {
-                margin-left: -@indent__base;
+                margin-left: 0;
             }
 
             &-item {
-                padding-left: @indent__base;
+                padding-left: 0;
             }
         }
     }
@@ -277,8 +277,8 @@
                 }
                 .sidebar & {
                     .product-item-photo {
-                        top: 9px;
                         left: 9px;
+                        top: 9px;
                     }
                 }
             }
@@ -310,8 +310,8 @@
         .actions-primary + .actions-secondary {
             display: table-cell;
             padding-left: 10px;
-            width: 50%;
             vertical-align: middle;
+            width: 50%;
 
             > .action {
                 margin-right: 10px;
diff --git a/app/design/frontend/Magento/luma/Magento_Catalog/web/css/source/module/_toolbar.less b/app/design/frontend/Magento/luma/Magento_Catalog/web/css/source/module/_toolbar.less
@@ -233,10 +233,10 @@
         }
     }
 
-    .limiter {
-        float: right;
-        .products.wrapper ~ .toolbar & {
+    .toolbar {
+        .products.wrapper ~ & .limiter {
             display: block;
+            float: right;
         }
     }
 }
diff --git a/lib/web/mage/adminhtml/form.js b/lib/web/mage/adminhtml/form.js
@@ -389,7 +389,7 @@ define([
             var idTo, idFrom, values, fromId, radioFrom;
 
             if (config) {
-                this._config = config;
+                this._config = jQuery.extend(this._config, config);
             }
 
             for (idTo in elementsMap) { //eslint-disable-line guard-for-in
diff --git a/lib/web/mage/apply/scripts.js b/lib/web/mage/apply/scripts.js
@@ -14,7 +14,7 @@ define([
         virtuals = [];
 
     /**
-     * Adds components to the virtula list.
+     * Adds components to the virtual list.
      *
      * @param {Object} components
      */

Original file line number	Diff line number	Diff line change
`@@ -188,11 +188,10 @@`
`188`	`188`	`.lib-icon-font-symbol(@icon-list);`
`189`	`189`	`}`
`190`	`190`
`191`		`- .limiter {`
`192`		`- float: right;`
`193`		`-`
`194`		`- .products.wrapper ~ .toolbar & {`
	`191`	`+ .toolbar {`
	`192`	`+ .products.wrapper ~ & .limiter {`
`195`	`193`	`display: block;`
	`194`	`+ float: right;`
`196`	`195`	`}`
`197`	`196`	`}`
`198`	`197`	`}`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,11 @@`
`35`	`35`	`.action {`
`36`	`36`	`&.showcart {`
`37`	`37`	`&:before {`
`38`		`- .lib-css(color, @primary__color);`
	`38`	`+ .lib-css(color, @button__color);`
	`39`	`+ }`
	`40`	`+`
	`41`	`+ &:hover:before {`
	`42`	`+ .lib-css(color, @button__hover__color);`
`39`	`43`	`}`
`40`	`44`	`}`
`41`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1402,7 +1402,7 @@`
`1402`	`1402`	`&.active {`
`1403`	`1403`	`> .title {`
`1404`	`1404`	`.lib-icon-font-symbol(`
`1405`		`- @_icon-font-content: @icon-prev,`
	`1405`	`+ @_icon-font-content: @icon-up,`
`1406`	`1406`	`@_icon-font-position: after`
`1407`	`1407`	`);`
`1408`	`1408`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,9 +20,7 @@`
`20`	`20`
`21`	`21`	`.media-width(@extremum, @break) when (@extremum = 'min') and (@break = @screen__m) {`
`22`	`22`	`.product.data.items {`
`23`		`- .lib-data-tabs(`
`24`		`- @_tab-content-border-top-status: true`
`25`		`- );`
	`23`	`+ .lib-data-tabs();`
`26`	`24`	`}`
`27`	`25`	`}`
`28`	`26`
Original file line number	Diff line number	Diff line change
`@@ -167,11 +167,11 @@`
`167`	`167`	`.column.main {`
`168`	`168`	`.product {`
`169`	`169`	`&-items {`
`170`		`- margin-left: -@indent__base;`
	`170`	`+ margin-left: 0;`
`171`	`171`	`}`
`172`	`172`
`173`	`173`	`&-item {`
`174`		`- padding-left: @indent__base;`
	`174`	`+ padding-left: 0;`
`175`	`175`	`}`
`176`	`176`	`}`
`177`	`177`	`}`
`@@ -277,8 +277,8 @@`
`277`	`277`	`}`
`278`	`278`	`.sidebar & {`
`279`	`279`	`.product-item-photo {`
`280`		`- top: 9px;`
`281`	`280`	`left: 9px;`
	`281`	`+ top: 9px;`
`282`	`282`	`}`
`283`	`283`	`}`
`284`	`284`	`}`
`@@ -310,8 +310,8 @@`
`310`	`310`	`.actions-primary + .actions-secondary {`
`311`	`311`	`display: table-cell;`
`312`	`312`	`padding-left: 10px;`
`313`		`- width: 50%;`
`314`	`313`	`vertical-align: middle;`
	`314`	`+ width: 50%;`
`315`	`315`
`316`	`316`	`> .action {`
`317`	`317`	`margin-right: 10px;`
Original file line number	Diff line number	Diff line change
`@@ -233,10 +233,10 @@`
`233`	`233`	`}`
`234`	`234`	`}`
`235`	`235`
`236`		`- .limiter {`
`237`		`- float: right;`
`238`		`- .products.wrapper ~ .toolbar & {`
	`236`	`+ .toolbar {`
	`237`	`+ .products.wrapper ~ & .limiter {`
`239`	`238`	`display: block;`
	`239`	`+ float: right;`
`240`	`240`	`}`
`241`	`241`	`}`
`242`	`242`	`}`
Original file line number	Diff line number	Diff line change
`@@ -389,7 +389,7 @@ define([`
`389`	`389`	`var idTo, idFrom, values, fromId, radioFrom;`
`390`	`390`
`391`	`391`	`if (config) {`
`392`		`- this._config = config;`
	`392`	`+ this._config = jQuery.extend(this._config, config);`
`393`	`393`	`}`
`394`	`394`
`395`	`395`	`for (idTo in elementsMap) { //eslint-disable-line guard-for-in`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ define([`
`14`	`14`	`virtuals = [];`
`15`	`15`
`16`	`16`	`/**`
`17`		`- * Adds components to the virtula list.`
	`17`	`+ * Adds components to the virtual list.`
`18`	`18`	`*`
`19`	`19`	`* @param {Object} components`
`20`	`20`	`*/`