Skip to content

#15308 removed extraneous margin #15936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

StevenGuapaBV
Copy link
Contributor

@StevenGuapaBV StevenGuapaBV commented Jun 7, 2018

removed extraneous margin and compensated padding and set both to 0, which creates the same effect

Description

Change in the theme which gives the same effect, but removes the negative margin which was compensated with a padding.

Fixed Issues (if relevant)

  1. extraneous margins on product list and product list items #15308: extraneous margins on product list and product list items

Manual testing scenarios

  1. open list view of products on a page
  2. inspect the list .column.main .product-items and one product .products-list .product-item
  3. check if the negative margin and positive padding are replaced by 0 and if the styling is still correct

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

removed extraneous margin and compensated padding and set both to 0, which creates the same effect
@VladimirZaets
Copy link
Contributor

Hi, @StevenGuapaBV, I took your PR into processing, thank you for collaboration.

@magento-engcom-team
Copy link
Contributor

Hi @StevenGuapaBV. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants