Skip to content

Sort by Product Name doesn't work with Ancor and available filters #12860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ihor-sviziev opened this issue Dec 22, 2017 · 15 comments
Closed

Sort by Product Name doesn't work with Ancor and available filters #12860

ihor-sviziev opened this issue Dec 22, 2017 · 15 comments
Assignees
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Dec 22, 2017

On the category page when we have filters (as example - we need to define color for products) + "Ancor" is enabled for category - sorting by product name doesn't work correct.

Preconditions

  1. Install Magento 2.2.2
  2. Create "test" category
  3. Create 3 products and add them to "test" category
  • Product A (color attribute set to "red")
  • Product B (color attribute set to "blue")
  • Cool Product C (color attribute set to "red")
  1. For "test" category in "Design" section change "Layout" to "1 column", save category
  2. For "test" category in "Design" section change "Layout Update XML" to "<referenceContainer name="main.content" htmlClass="page-main products-grid--max-4-col"/>", save category

Steps to reproduce

  1. Go to frontend >> Test category
  2. Change "Sort" to "Product Name"

Expected result

  1. Products should be sorder by name (when ancor disabled - it works good)
    image
    image

Actual result

  1. Products are not sorted by name (product B should be 3rd, but it is second) image
  2. Sorting by desc also doesn't work:
    image

We hadn't this issue in Magento 2.1.x, it appeared during upgrade to 2.2, so probably it's regression.

Video where I was able to reproduce it: https://photos.app.goo.gl/tfRvSIcYYNN90jUB2

@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Dec 22, 2017
@magento-engcom-team
Copy link
Contributor

Hello @ihor-sviziev. Thanks for reporting. Currently we are not able to reproduce Your issue. We tried to do that on a clear instance of Magento and recorded a video about that. In fact there are three separate videos : Video1, Video2 and Video3. Please watch them in that order and tell us what we have missed or done not as You have.
Video1.zip
Video2.zip
Video3.zip

@ihor-sviziev
Copy link
Contributor Author

Hi @magento-engcom-team,

I was able to reproduce on fresh magento installation, will try to check steps to reproduce, probably there is mistake. Will update you later

@ihor-sviziev
Copy link
Contributor Author

ihor-sviziev commented Jan 2, 2018

Looks like this issue reproducing not every time, will try to record video or define more clear steps to reproduce.

@ihor-sviziev
Copy link
Contributor Author

ihor-sviziev commented Jan 2, 2018

@magento-engcom-team I've updated steps to reproduce, also I prepared video where I reproduced this issue. Link to video: https://photos.app.goo.gl/tfRvSIcYYNN90jUB2

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jan 3, 2018
@magento-engcom-team
Copy link
Contributor

@ihor-sviziev, thank you for your report.
We've created internal ticket(s) MAGETWO-86296 to track progress on the issue.

@okorshenko
Copy link
Contributor

okorshenko commented Feb 2, 2018

Hi @ihor-sviziev. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1192 by @p-bystritsky in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.4 release.

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Feb 2, 2018
ihor-sviziev pushed a commit to ihor-sviziev/magento2 that referenced this issue Feb 2, 2018
@ihor-sviziev
Copy link
Contributor Author

@p-bystritsky thank you so much for fixing it!

@SatishDubariya
Copy link

Product Sorting Not works for 1column layout.
I have installed fresh magento 2.2.2 with sample data and change Category Page Layout to 1 Column for Jackets Category in Women > Tops.
But after that when i tried to sort products by Name and Position, i found that it is not sorting.

position-desc
position-asc
name-asc
name-desc

@ihor-sviziev
Copy link
Contributor Author

@SatishDubariya fix for this issue is here: e5b030a
You can apply this patch for your project.
Here is example how to apply it: https://gist.github.com/amenk/908e80748662d896718685c778cd4db4

@vberthet
Copy link

Same problem with magento 2.1.14.

Fix in #13468 works. Please merge in 2.1.x

ihor-sviziev pushed a commit to ihor-sviziev/magento2 that referenced this issue Jul 19, 2018
@ihor-sviziev
Copy link
Contributor Author

@vberthet I created PR for fixing it in 2.1.x

@sidolov
Copy link
Contributor

sidolov commented Jul 21, 2018

Hi @ihor-sviziev. Thank you for your report.
The issue has been fixed in #16945 by @ihor-sviziev in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jul 21, 2018
@magejunkie
Copy link

@ihor-sviziev I am on Magento 2.2.3 and this issue persists.

@ihor-sviziev
Copy link
Contributor Author

@magejunkie, just update to latest version and this issue should go away

@magento2dev
Copy link

magento2dev commented Mar 18, 2019

Hi @ihor-sviziev. Thank you for your report.
The issue has been fixed in #16945 by @ihor-sviziev in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

I'm on Magento 2.2 and I tried to apply this fix but I still get the issue (not filtering by product name and showing more products than toolbar defined) is there anything else to do ?

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

9 participants