Skip to content

Elasticsearch category page issues when 1 column layout is used #24619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arendarenko opened this issue Sep 16, 2019 · 12 comments
Closed

Elasticsearch category page issues when 1 column layout is used #24619

arendarenko opened this issue Sep 16, 2019 · 12 comments
Labels
Component: Elasticsearch Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Severity: S1 Affects critical data or functionality and forces users to employ a workaround.

Comments

@arendarenko
Copy link
Contributor

arendarenko commented Sep 16, 2019

Preconditions (*)

  1. Magento 2.3.2 CE and 2.3-develop
  2. Installed & configured Elasticsearch 6.5

Steps to reproduce (*)

  1. Choose category with products and set 1 column design to it (Catalog -> Categories -> Edit Category -> Design -> Layout -> "1 column"
  2. Save category
  3. Flush cache
  4. Open this category on website and change sort order to "Price"
  5. Go to page 2

Expected result (*)

  1. Products will be sorted by price

Actual result (*)

On 2.3.2:

  1. Products is sorted the same way they was sorted before

On 2.3-develop (with 23b0061):

  1. Products is showing correctly on page 1 (right sort order used) but there is no products at page 2:

image

@m2-assistant
Copy link

m2-assistant bot commented Sep 16, 2019

Hi @alexeya-ven. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@alexeya-ven do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 16, 2019
@arendarenko arendarenko changed the title Elasticsearch catalog sort doesn't work if 1 column layout is specified Elasticsearch catalog sort doesn't work if 1 column layout is used Sep 16, 2019
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Sep 16, 2019

Similar issue we had with MySQL search long time ago in #12860.

@engcom-Alfa could you verify this issue?

@m2-assistant
Copy link

m2-assistant bot commented Sep 17, 2019

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Charlie
Copy link
Contributor

Hello @alexeya-ven .
I can't reproduce this issue on fresh Magento 2.3-develop.

Manual testing scenario:

  1. Enable Elasticsearch 6
  2. Choose category with products and set 1 column design to it (Catalog -> Categories -> Edit Category -> Design -> Layout -> "1 column"
  3. Save category
  4. Flush cache
  5. Open this category on website and change sort order to "Price"

Actual result:
Sort by price works fine:
image

Could you reproduce this issue on Magento 2.3-develop?

@arendarenko
Copy link
Contributor Author

arendarenko commented Sep 17, 2019

Hi @engcom-Charlie,
You're right! Looks like this issue was fixed in 23b0061
BUT it introduced another issue - on 2nd page and higher - no products.
Just checked on 2.3-deveop + sample data.
image

I've updated issue description.

@arendarenko arendarenko changed the title Elasticsearch catalog sort doesn't work if 1 column layout is used Elasticsearch category page issues when 1 column layout is used Sep 17, 2019
@ghost ghost assigned arendarenko Sep 17, 2019
@engcom-Charlie engcom-Charlie added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release and removed Progress: needs update labels Sep 17, 2019
@ghost ghost unassigned engcom-Charlie Sep 17, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 17, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-20203 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@ghost ghost unassigned arendarenko Sep 30, 2019
@jorgb90
Copy link

jorgb90 commented Oct 17, 2019

I got this same problem but with all layouts, so not only 1 column layout.. Only first page show products with Elasticsearch!

@arendarenko I am using Magento 2.3.3 have any way to fix it?

Edit: Fixed my problem with the available Magento 2.3.3 patch. Should have looked for one first..

@ArthurSCD
Copy link

On Magento 2.3.2, encountered this issue and more - pagination was missing completely.

On Magento 2.3.3, issue remains, even after the patch has been applied. Not only that, category sorting does not work at all, both with the sort and the category ordering set in the backend.

@ArthurSCD
Copy link

I can confirm that even with the patch in #25107 on Vanilla sample data 2.3.3, issue remains on ONE COLUMN layout. Note that it seems to work fine if the category is accessed through Layered Navigation.

ss (2019-10-22 at 03 36 20)

Surprisingly sorting does seem to work 1 column, Elasticsearch, 2.3.3 Vanilla instance, although it certainly does not for the site I encountered the issues. Should note that changing to MYSQL from Elastic immediately resolves all issues. 2.3.1 is also fine, but I had just checked the elasticsearch module to see quite a bit was reworked in 2.3.2. Completely new files etc.

@ghost ghost removed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Oct 20, 2020
@magento-engcom-team magento-engcom-team added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Nov 30, 2020
@engcom-Kilo
Copy link
Contributor

Hello @arendarenko
I'm not able to reproduce this issue on latest 2.4-develop
OneCulumnLayoutUpdate
Could you please add more details, or correct steps I did?

@magento-engcom-team
Copy link
Contributor

Hi @arendarenko.

Thank you for your report and collaboration!

The related internal Jira ticket MC-24209 was closed as Fixed.

The fix will be available with the upcoming 2.4.2 release.

@magento-engcom-team
Copy link
Contributor

Hi @arendarenko.

Thank you for your report and collaboration!

The related internal Jira ticket MC-24209 was closed as Fixed.

The fix will be available with the upcoming 2.4.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Elasticsearch Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
Archived in project
Development

No branches or pull requests

8 participants