Status downloadable product stays pending after succesfull payment #22545

KooTjoo · 2019-04-29T17:04:43Z

When a downloadable product has been order and paid for download status should automatically become available. Status remains pending although order is invoiced and completed automatically by payment processor. When order is invoiced from admin it all works.

Preconditions (*)

Magento 2.3.1 CE
PHP 7.2

Steps to reproduce (*)

Setup Magento site with demo contents
Order Item Status to Enable Downloads->Invoiced
Setup Payment for instance Paypal
Make purchase of downloadable product with payment method Paypal
Make sure payment is succesfull (Order status is completed)

Expected result (*)

Download link should be available in customer account
Status of downloadable product should be available

Actual result (*)

In customer account order status is completed
In customer account downloadable product is pending

When an order is placed and in Magento admin the order is invoiced the it works as it should. So somehow downloadable status is not changed when an order is automatically set to completed when payment is succesfull.

This issue occured only after upgrading to Magento 2.3.1 in 2.3.0 it all worked like it should.

m2-assistant · 2019-04-29T17:04:45Z

Hi @KooTjoo. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@KooTjoo do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

yes
no

m2-assistant · 2019-04-29T18:42:53Z

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
6. Add label Issue: Confirmed once verification is complete.
7. Make sure that automatic system confirms that report has been added to the backlog.

magento-engcom-team · 2019-04-29T19:45:01Z

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99452 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant · 2019-04-30T04:07:02Z

Hi @sourabhmodi60. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
3. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

4. If the issue is not relevant or is not reproducible any more, feel free to close it.

m2-assistant · 2019-04-30T06:48:18Z

Hi @shikhamis11. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

3. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
4. If the issue is not relevant or is not reproducible any more, feel free to close it.

m2-assistant · 2019-04-30T13:04:18Z

Hi @GovindaSharma. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

3. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
4. If the issue is not relevant or is not reproducible any more, feel free to close it.

shikhamis11 · 2019-05-04T04:16:20Z

I am working on this at #dmcdindia1

…uccesfull payment

saeohioalpha · 2019-07-03T14:06:02Z

To fix this without waiting for the PR to be approved and pushed to the next release.

Edit vendor/magento/module-downloadable/Observer/SaveDownloadableOrderItemObserver.php
a. Apply changes on lines specified in:
https://github.com/magento/magento2/pull/22658/files
b. See changes inline in full file:
https://github.com/raw/magento/magento2/1524687560c4a71322eefd4448ff79d9ea334ac9/app/code/Magento/Downloadable/Observer/SaveDownloadableOrderItemObserver.php
Also (pre-2.3.2) make sure Lines 95-100 match as well. These were changed in 2.3.2
$storeId = $orderItem->getOrder()->getStoreId();
$orderStatusToEnableItem = $this->_scopeConfig->getValue(
\Magento\Downloadable\Model\Link\Purchased\Item::XML_PATH_ORDER_ITEM_STATUS,
ScopeInterface::SCOPE_STORE,
$storeId
);
Recompile/Redeploy:
a. bin/magento deploy:mode:set developer
b. bin/magento deploy:mode:set production

Testing on my store, this fixes the download link problem.

magento-engcom-team · 2019-07-07T23:10:11Z

Hi @KooTjoo. Thank you for your report.
The issue has been fixed in #22658 by @shikhamis11 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.3 release.

…fter succesfu… #22658 - Merge Pull Request #22658 from opencommerce/magento2:2.3-developPr22545 - Merged commits: 1. c4dc289 2. 7174745 3. 630bbb5 4. a800c6b 5. e2f06b3 6. 1524687

…fter succesfu… #22658

janmech · 2019-10-27T16:49:09Z

i came up with a very simple fix (though) it probably needs further testing. I figured that the problem is that changes/new entries in downloadable_link_purchased are not yet committed when SaveDownloadableOrderItemObserver is executed.

my 1-line fix/proposition is changing the module-downloadable/etc/events.xml:
FROM:

TO:
<event name="sales_order_save_commit_after">
<observer name="downloadable_observer" instance="Magento\Downloadable\Observer\SetLinkStatusObserver" />
<observer name="downloadable_observer_assign_customer" instance="Magento\Downloadable\Observer\UpdateLinkPurchasedObserver" />
</event>

magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 29, 2019

shikhamis11 self-assigned this Apr 29, 2019

ghost unassigned shikhamis11 Apr 29, 2019

magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 29, 2019

sourabhmodi60 self-assigned this Apr 30, 2019

shikhamis11 self-assigned this Apr 30, 2019

GovindaSharma self-assigned this Apr 30, 2019

shikhamis11 added the Event: dmcdindia1 label May 4, 2019

shikhamis11 pushed a commit to opencommerce/magento2 that referenced this issue May 4, 2019

Fixed magento#22545 Status downloadable product stays pending after s…

c4dc289

…uccesfull payment

shikhamis11 mentioned this issue May 4, 2019

Fixed #22545 Status downloadable product stays pending after succesfu… #22658

Merged

4 tasks

krishprakash mentioned this issue Jul 3, 2019

Downloadable product status not updating despite invoice being paid and order complete. #23549

Closed

magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jul 7, 2019

magento-engcom-team closed this as completed Jul 7, 2019

magento-engcom-team pushed a commit that referenced this issue Jul 7, 2019

ENGCOM-5157: Fixed #22545 Status downloadable product stays pending a…

25981de

…fter succesfu… #22658

SR71Mach3 mentioned this issue Oct 24, 2019

No download link in customer account after purchases in 2.3.1. #22354

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Status downloadable product stays pending after succesfull payment #22545

Status downloadable product stays pending after succesfull payment #22545

KooTjoo commented Apr 29, 2019 •

edited

Loading

m2-assistant bot commented Apr 29, 2019

Uh oh!

m2-assistant bot commented Apr 29, 2019 •

edited by shikhamis11

Loading

Uh oh!

magento-engcom-team commented Apr 29, 2019

Uh oh!

m2-assistant bot commented Apr 30, 2019 •

edited by sourabhmodi60

Loading

Uh oh!

m2-assistant bot commented Apr 30, 2019 •

edited by ansari-ziyaurrahman

Loading

Uh oh!

m2-assistant bot commented Apr 30, 2019

Uh oh!

shikhamis11 commented May 4, 2019

Uh oh!

saeohioalpha commented Jul 3, 2019

Uh oh!

magento-engcom-team commented Jul 7, 2019

Uh oh!

janmech commented Oct 27, 2019 •

edited

Loading

Uh oh!

Status downloadable product stays pending after succesfull payment #22545

Status downloadable product stays pending after succesfull payment #22545

Comments

KooTjoo commented Apr 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Actual result (*)

m2-assistant bot commented Apr 29, 2019

Uh oh!

m2-assistant bot commented Apr 29, 2019 • edited by shikhamis11 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

magento-engcom-team commented Apr 29, 2019

Uh oh!

m2-assistant bot commented Apr 30, 2019 • edited by sourabhmodi60 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m2-assistant bot commented Apr 30, 2019 • edited by ansari-ziyaurrahman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m2-assistant bot commented Apr 30, 2019

Uh oh!

shikhamis11 commented May 4, 2019

Uh oh!

saeohioalpha commented Jul 3, 2019

Uh oh!

magento-engcom-team commented Jul 7, 2019

Uh oh!

janmech commented Oct 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KooTjoo commented Apr 29, 2019 •

edited

Loading

m2-assistant bot commented Apr 29, 2019 •

edited by shikhamis11

Loading

m2-assistant bot commented Apr 30, 2019 •

edited by sourabhmodi60

Loading

m2-assistant bot commented Apr 30, 2019 •

edited by ansari-ziyaurrahman

Loading

janmech commented Oct 27, 2019 •

edited

Loading