Fixed #22545 Status downloadable product stays pending after succesfu… #22658

shikhamis11 · 2019-05-04T07:19:31Z

Fixed #22545 Status downloadable product stays pending after succesfull payment

When a downloadable product has been order and paid for download status should automatically become available. Status remains pending although order is invoiced and completed automatically by payment processor. When order is invoiced from admin it all works.

Preconditions (*)

Magento 2.3.1 CE
PHP 7.2

Steps to reproduce (*)

Setup Magento site with demo contents
Order Item Status to Enable Downloads->Invoiced
Setup Payment for instance Paypal
Make purchase of downloadable product with payment method Paypal
Make sure payment is succesfull (Order status is completed)

Expected result (*)

Download link should be available in customer account
Status of downloadable product should be available

Actual result (*)

In customer account order status is completed
In customer account downloadable product is pending

When an order is placed and in Magento admin the order is invoiced the it works as it should. So somehow downloadable status is not changed when an order is automatically set to completed when payment is succesfull.

This issue occured only after upgrading to Magento 2.3.1 in 2.3.0 it all worked like it should.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

…uccesfull payment

m2-assistant · 2019-05-04T07:19:34Z

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

dmytro-ch · 2019-05-09T15:50:16Z

app/code/Magento/Downloadable/Observer/SaveDownloadableOrderItemObserver.php

+
+                $linkstatus =  \Magento\Downloadable\Model\Link\Purchased\Item::LINK_STATUS_PENDING;
+               if( $orderStatusToEnableItem == \Magento\Sales\Model\Order\Item::STATUS_PENDING
+                    || $orderItem->getOrder()->getStatus() == \Magento\Sales\Model\Order::STATE_COMPLETE){


I guess we should use the getState instead of getStatus method in this case.
Could you please check this point?

dmytro-ch · 2019-05-09T15:50:48Z

app/code/Magento/Downloadable/Observer/SaveDownloadableOrderItemObserver.php

@@ -131,6 +131,13 @@ public function execute(\Magento\Framework\Event\Observer $observer)
                        ScopeInterface::SCOPE_STORE
                    );
                $linkPurchased->setLinkSectionTitle($linkSectionTitle)->save();
+
+                $linkstatus =  \Magento\Downloadable\Model\Link\Purchased\Item::LINK_STATUS_PENDING;


Could you please change the variable name to $linkStatus?

dmytro-ch · 2019-05-09T15:59:10Z

app/code/Magento/Downloadable/Observer/SaveDownloadableOrderItemObserver.php

@@ -131,6 +131,13 @@ public function execute(\Magento\Framework\Event\Observer $observer)
                        ScopeInterface::SCOPE_STORE
                    );
                $linkPurchased->setLinkSectionTitle($linkSectionTitle)->save();
+
+                $linkstatus =  \Magento\Downloadable\Model\Link\Purchased\Item::LINK_STATUS_PENDING;
+               if( $orderStatusToEnableItem == \Magento\Sales\Model\Order\Item::STATUS_PENDING


Please fix minor styling issues for if statement according to PSR-2 standard (spacings etc.).
An if structure should look like the following:

if ($a == $b || $b == $c || $c == $d ) { // code here }

shikhamis11 · 2019-05-10T12:18:10Z

@dmytro-ch, Thanks for your review.
I have updated changes Please check

dmytro-ch · 2019-05-13T11:40:39Z

@shikhamis11, could you please also check and fix the static test failures.
Once the changes are applied, please squash all commits into a single one in order to cleanup history.
Thank you!

shikhamis11 · 2019-05-15T14:11:28Z

sure I will

magento-engcom-team · 2019-05-24T19:11:35Z

Hi @sidolov, thank you for the review.
ENGCOM-5157 has been created to process this Pull Request

soleksii · 2019-05-27T10:43:37Z

Hi @shikhamis11 !

I cannot reproduce the issue #22545 .

Manual testing scenario:

Create Order with downloadable product (PayPay Express Checkout);
Automatically create invoice;

Actual result:
My orders:

My Downloadable Products:

Could you take a look, please?

shikhamis11 · 2019-05-31T11:31:18Z

hello @stoleksiy
I will check and update you

Robert-Sheahan · 2019-06-15T20:34:13Z

I have had this problem for a few months now. My website is completely down as customers cannot get downloadable purchase. Just wondering when and how this fix would be released. Thanks.

shikhamis11 · 2019-06-27T13:05:45Z

hello @stoleksiy
I checked at latest magento version not with paypal payment method but with my virtual payment method i.e 'wallet' and after order palce the order status is completed item status is invoiced but the in My Downloadable Products the product link is not available. so I guess issue still exists ..
can you please recheck once at your end

KooTjoo · 2019-06-29T15:43:48Z

I have had this problem for a few months now. My website is completely down as customers cannot get downloadable purchase. Just wondering when and how this fix would be released. Thanks.

Well that can be fixed easily by applying the fixes mentioned, next to that it is easy to update this in your DB. No need for a website to be completely down for this.

Robert-Sheahan · 2019-06-29T17:27:11Z

I have had this problem for a few months now. My website is completely down as customers cannot get downloadable purchase. Just wondering when and how this fix would be released. Thanks.

Well that can be fixed easily by applying the fixes mentioned, next to that it is easy to update this in your DB. No need for a website to be completely down for this.

KooTjoo, Thanks for the reply. I am a skilled Magento user but not a developer. I see code changes, testing and test failures in these threads. I do not see any quick fix. If there was an option that needed to be changed in the Admin, I could do that, but I am not trained in PHP or how to update code. Yes the site is completely down, as customers buy a product but do not get the link to download the file. They try to buy it again and again until they give up. Then they think I am going to mail something and when nothing arrives I get complaints from PayPal. I contacted dozens of developers for help but only one replied and they required $900 to start looking at it. I keep hoping for a quick fix being that it is such a serious problem. Any ideas? Thanks Bob

KooTjoo · 2019-06-29T17:35:50Z

I have had this problem for a few months now. My website is completely down as customers cannot get downloadable purchase. Just wondering when and how this fix would be released. Thanks.
Well that can be fixed easily by applying the fixes mentioned, next to that it is easy to update this in your DB. No need for a website to be completely down for this.

KooTjoo, Thanks for the reply. I am a skilled Magento user but not a developer. I see code changes, testing and test failures in these threads. I do not see any quick fix. If there was an option that needed to be changed in the Admin, I could do that, but I am not trained in PHP or how to update code. Yes the site is completely down, as customers buy a product but do not get the link to download the file. They try to buy it again and again until they give up. Then they think I am going to mail something and when nothing arrives I get complaints from PayPal. I contacted dozens of developers for help but only one replied and they required $900 to start looking at it. I keep hoping for a quick fix being that it is such a serious problem. Any ideas? Thanks Bob

It is a 5 minute fix so $900?????? I don't know how to get into contact with you to discuss further otherwise we could help you.

jkeller92 · 2019-07-02T08:32:27Z

The Problem is that the Observer Magento\Downloadable\Observer\SaveDownloadableOrderItemObserver sets $linkPurchasedItem status to pending in every case.

We need a function that provides the correct status instead of forcing pending-Status

something like this: (conditions are copied from Magento\Downloadable\Observer\SetLinkStatusObserver)

...

...
/**
* Function provides correct downloadLink Status
*
* @param $orderItem
* @return string
*/
    protected function _getStatus($orderItem)
    {
        $orderStatus = \Magento\Downloadable\Model\Link\Purchased\Item::LINK_STATUS_PENDING;

        $order = $orderItem->getOrder();

        if (!$order || !$order->getId()) {
            return $orderStatus;
        }

        $orderItemStatusToEnable = $this->_scopeConfig->getValue(
            \Magento\Downloadable\Model\Link\Purchased\Item::XML_PATH_ORDER_ITEM_STATUS,
            ScopeInterface::SCOPE_STORE,
            $order->getStoreId()
        );

        if ($order->getState() == \Magento\Sales\Model\Order::STATE_HOLDED) {
            $orderStatus = \Magento\Downloadable\Model\Link\Purchased\Item::LINK_STATUS_PENDING;
        } elseif ($order->isCanceled()
            || $order->getState() == \Magento\Sales\Model\Order::STATE_CLOSED
            || $order->getState() == \Magento\Sales\Model\Order::STATE_COMPLETE
        ) {
            $expiredStatuses = [
                \Magento\Sales\Model\Order\Item::STATUS_CANCELED,
                \Magento\Sales\Model\Order\Item::STATUS_REFUNDED,
            ];

            if ($orderItem->getProductType() == \Magento\Downloadable\Model\Product\Type::TYPE_DOWNLOADABLE
                || $orderItem->getRealProductType() == \Magento\Downloadable\Model\Product\Type::TYPE_DOWNLOADABLE
            ) {
                if ($order->isCanceled() || in_array($orderItem->getStatusId(), $expiredStatuses)) {
                    $orderStatus = \Magento\Downloadable\Model\Link\Purchased\Item::LINK_STATUS_EXPIRED;
                } else {
                    $orderStatus = \Magento\Downloadable\Model\Link\Purchased\Item::LINK_STATUS_AVAILABLE;
                }
            }
        } elseif ($order->getState() == \Magento\Sales\Model\Order::STATE_PENDING_PAYMENT) {
            $orderStatus = \Magento\Downloadable\Model\Link\Purchased\Item::LINK_STATUS_PENDING_PAYMENT;
        } elseif ($order->getState() == \Magento\Sales\Model\Order::STATE_PAYMENT_REVIEW) {
            $orderStatus = \Magento\Downloadable\Model\Link\Purchased\Item::LINK_STATUS_PAYMENT_REVIEW;
        } else {
            $availableStatuses = [$orderItemStatusToEnable, \Magento\Sales\Model\Order\Item::STATUS_INVOICED];

            if ($orderItem->getProductType() == \Magento\Downloadable\Model\Product\Type::TYPE_DOWNLOADABLE
                    || $orderItem->getRealProductType() == \Magento\Downloadable\Model\Product\Type::TYPE_DOWNLOADABLE
                ) {
                if ($orderItem->getStatusId() == \Magento\Sales\Model\Order\Item::STATUS_BACKORDERED
                        && $orderItemStatusToEnable == \Magento\Sales\Model\Order\Item::STATUS_PENDING
                        && !in_array(
                            \Magento\Sales\Model\Order\Item::STATUS_BACKORDERED,
                            $availableStatuses,
                            true
                        )
                    ) {
                    $availableStatuses[] = \Magento\Sales\Model\Order\Item::STATUS_BACKORDERED;
                }

                if (in_array($orderItem->getStatusId(), $availableStatuses)) {
                    $orderStatus = \Magento\Downloadable\Model\Link\Purchased\Item::LINK_STATUS_AVAILABLE;
                }
            }
        }

        return $orderStatus;
    }

saeohioalpha · 2019-07-03T13:18:46Z

@stoleksiy I just reported this issue in #23549. It definitely still exists. I also verified it exists on the 2.3-develop instance.

sivaschenko · 2019-07-03T16:20:06Z

@magento run Functional Tests build

engcom-Delta · 2019-07-05T10:47:11Z

✔️ QA passed

m2-assistant · 2019-07-07T23:11:56Z

Hi @shikhamis11, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

…fter succesfu… #22658

Robert-Sheahan · 2019-07-08T18:31:08Z

Great, it looks like a fix is in. I have had this problem for months now. My website is completely down as customers do not get link to downloadable purchase. Just wondering when and how Release 2.3.3 would be released. Thanks.

Fixed magento#22545 Status downloadable product stays pending after s…

c4dc289

…uccesfull payment

magento-engcom-team added Component: Downloadable Release Line: 2.3 labels May 4, 2019

magento-engcom-team added Community Insider: Cedcommerce community-insider-contribution labels May 4, 2019

dmytro-ch self-requested a review May 5, 2019 18:28

dmytro-ch self-assigned this May 5, 2019

dmytro-ch requested changes May 9, 2019

View reviewed changes

ghost added the Progress: needs update label May 9, 2019

Updated requested changes

7174745

Updated variable name

630bbb5

Shikha Mishra added 3 commits May 23, 2019 18:32

Fixed Static Test

a800c6b

Fixed Static test

e2f06b3

Fixed Static Test

1524687

sidolov approved these changes May 24, 2019

View reviewed changes

ghost assigned sidolov May 24, 2019

ghost added Progress: ready for testing and removed Progress: needs update labels May 24, 2019

soleksii self-assigned this May 27, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels May 27, 2019

Nazar65 self-assigned this May 27, 2019

ghost added Progress: needs update and removed Progress: testing in progress labels May 27, 2019

engcom-Delta assigned engcom-Delta and unassigned Nazar65 and soleksii Jul 5, 2019

ghost added Progress: testing in progress and removed Progress: needs update labels Jul 5, 2019

ghost added Progress: extended testing Progress: accept and removed Progress: testing in progress Progress: extended testing labels Jul 5, 2019

magento-engcom-team mentioned this pull request Jul 7, 2019

Status downloadable product stays pending after succesfull payment #22545

Closed

magento-engcom-team merged commit 1524687 into magento:2.3-develop Jul 7, 2019

magento-engcom-team added this to the Release: 2.3.3 milestone Jul 7, 2019

magento-engcom-team pushed a commit that referenced this pull request Jul 7, 2019

ENGCOM-5157: Fixed #22545 Status downloadable product stays pending a…

25981de

…fter succesfu… #22658

sidolov added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 14, 2019

Fixed #22545 Status downloadable product stays pending after succesfu… #22658

Fixed #22545 Status downloadable product stays pending after succesfu… #22658

Uh oh!

Conversation

shikhamis11 commented May 4, 2019

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Actual result (*)

Contribution checklist (*)

Uh oh!

m2-assistant bot commented May 4, 2019

Uh oh!

dmytro-ch May 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shikhamis11 May 10, 2019

Choose a reason for hiding this comment

Uh oh!

dmytro-ch May 9, 2019

Choose a reason for hiding this comment

Uh oh!

shikhamis11 May 10, 2019

Choose a reason for hiding this comment

Uh oh!

dmytro-ch May 9, 2019

Choose a reason for hiding this comment

Uh oh!

shikhamis11 May 10, 2019

Choose a reason for hiding this comment

Uh oh!

shikhamis11 commented May 10, 2019

Uh oh!

dmytro-ch commented May 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shikhamis11 commented May 15, 2019

Uh oh!

magento-engcom-team commented May 24, 2019

Uh oh!

soleksii commented May 27, 2019

Uh oh!

shikhamis11 commented May 31, 2019

Uh oh!

Robert-Sheahan commented Jun 15, 2019

Uh oh!

shikhamis11 commented Jun 27, 2019

Uh oh!

KooTjoo commented Jun 29, 2019

Uh oh!

Robert-Sheahan commented Jun 29, 2019

Uh oh!

KooTjoo commented Jun 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkeller92 commented Jul 2, 2019

Uh oh!

saeohioalpha commented Jul 3, 2019

Uh oh!

sivaschenko commented Jul 3, 2019

Uh oh!

engcom-Delta commented Jul 5, 2019

Uh oh!

m2-assistant bot commented Jul 7, 2019

Uh oh!

Robert-Sheahan commented Jul 8, 2019

Uh oh!

Uh oh!

dmytro-ch May 9, 2019 •

edited

Loading

dmytro-ch commented May 13, 2019 •

edited

Loading

KooTjoo commented Jun 29, 2019 •

edited

Loading