Skip to content

New Shipment emails do not generate #22788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DigitalStartupUK opened this issue May 8, 2019 · 16 comments
Closed

New Shipment emails do not generate #22788

DigitalStartupUK opened this issue May 8, 2019 · 16 comments
Assignees
@gulshanchitransh @mahesh-rajawat @gaurav-473
Labels
Component: Email Component: Sales Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@DigitalStartupUK
Copy link

Preconditions (*)

  1. Magento 2.3.1 Open Source
  2. Ubuntu 16.04, PHP 7.2, Apache 2.4.18

Steps to reproduce (*)

  1. Go to Marketing > Email Templates
  2. Add Template
  3. Load magento_sales > New Shipment (Default Template with no custom changes)
  4. Press Load
  5. Preview Template

Expected result (*)

  1. The Template Preview Tab loads with the default contents

Actual result (*)

  1. The Template Preview Tab is blank. The only HTML source code is below
<html lang="en"><head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
    <title>Email Preview</title>
</head>
<body>
    </body>
</html>

Further Notes: When you remove the below line from the Default Template, the Template Preview loads:

{{block class='Magento\\Framework\\View\\Element\\Template' area='frontend' template='Magento_Sales::email/shipment/track.phtml' shipment=$shipment order=$order}}

template-ok
@m2-assistant
Copy link

m2-assistant bot commented May 8, 2019

Hi @DigitalStartupUK. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@DigitalStartupUK do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 8, 2019
@deepikajaniyani
Copy link

deepikajaniyani commented May 8, 2019 •
edited
Loading

@magento-engcom-team give me 2.3-develop instance

As checked on a vanilla Magento 2.3.1 instance this issue replicates.

@magento-engcom-team
Copy link
Contributor

Hi @deepikajaniyani. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @deepikajaniyani, here is your Magento instance.
Admin access: https://i-22788-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@gaurav-473 gaurav-473 self-assigned this May 8, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 8, 2019

Hi @gauravagarwal1001. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.
    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

@deepikajaniyani
Copy link

@magento-engcom-team this issue replicates on 2.3.x version, please add the label. I am not able to do so.

@gaurav-473 gaurav-473 mentioned this issue May 8, 2019
Merged
@shikhamis11 shikhamis11 self-assigned this May 8, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 8, 2019

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@shikhamis11
Copy link
Member

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@shikhamis11
Copy link
Member

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11, here is your Magento instance.
Admin access: https://i-22788-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@shikhamis11 shikhamis11 added Component: Email Component: Sales Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels May 8, 2019
@ghost ghost unassigned shikhamis11 May 8, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99611, MAGETWO-99612 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 8, 2019
@shikhamis11 shikhamis11 added the Progress: PR Created Indicates that Pull Request has been created to fix issue label May 8, 2019
@subbu1993
Copy link

@magento-engcom-team please give me 2.3.x instance

@gulshanchitransh gulshanchitransh self-assigned this May 10, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 10, 2019

Hi @gulshanchitransh. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

magento-engcom-team added a commit to okorshenko/magento2 that referenced this issue May 14, 2019
@magento-engcom-team
ENGCOM-5090: Fixed issue magento#22788 magento#22791
70fa33d 
 - Merge Pull Request magento#22791 from gauravagarwal1001/magento2:2.3-developPr22788
 - Merged commits:
   1. 84da62e
magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this issue May 14, 2019
@sidolov
ENGCOM-5090: Fixed issue magento#22788 magento#22791
63fda1a
@mahesh-rajawat mahesh-rajawat mentioned this issue May 15, 2019
Merged
@ghost ghost assigned mahesh-rajawat May 15, 2019
mahesh-rajawat pushed a commit to mahesh-rajawat/magento2 that referenced this issue May 15, 2019
@gaurav-473 @mahesh-rajawat
Fixed issue magento#22788
a387566
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label May 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @DigitalStartupUK. Thank you for your report.
The issue has been fixed in #22906 by @maheshWebkul721 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.10 release.

magento-engcom-team added a commit that referenced this issue May 20, 2019
@magento-engcom-team
ENGCOM-5127: [Backport] Fixed issue #22788 #22906
6a62e0a 
 - Merge Pull Request #22906 from maheshWebkul721/magento2:2.2-develop-PR-port-22791
 - Merged commits:
   1. a387566
magento-engcom-team pushed a commit that referenced this issue May 20, 2019
@VladimirZaets
ENGCOM-5127: [Backport] Fixed issue #22788 #22906
ad6b9ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gulshanchitransh gulshanchitransh

@mahesh-rajawat mahesh-rajawat

@gaurav-473 gaurav-473

Labels
Component: Email Component: Sales Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@deepikajaniyani @subbu1993 @DigitalStartupUK @shikhamis11 @gulshanchitransh @magento-engcom-team @mahesh-rajawat @gaurav-473